Mojo: Implement the rest of the WebSocket interface.

Mojo: Implement the rest of the WebSocket interface.

Also moved some generic TypeConverters to a separate file.

BUG=403930
Committed: https://crrev.com/2cbe08dab14cb1f72f3ec478d52941d0bca2fa55
Cr-Commit-Position: refs/heads/master@{#293801}

[Matt Perry, 2014-09-03 23:59:50]

mpcomplete@chromium.org changed reviewers:
+ darin@chromium.org

[darin (slow to review), 2014-09-05 18:54:15]

LGTM

sorry for the high latency code review

https://codereview.chromium.org/540683002/diff/1/mojo/services/html_viewer/we...
File mojo/services/html_viewer/websockethandle_impl.cc (right):

https://codereview.chromium.org/540683002/diff/1/mojo/services/html_viewer/we...
mojo/services/html_viewer/websockethandle_impl.cc:122: // |handle_| can be
deleted here.
hmm, this comment is a bit fishy since |this| is already deleted. maybe the
comment should say "handle" instead of "handle_"? ditto for the others?

[Matt Perry, 2014-09-05 19:49:08]

https://codereview.chromium.org/540683002/diff/1/mojo/services/html_viewer/we...
File mojo/services/html_viewer/websockethandle_impl.cc (right):

https://codereview.chromium.org/540683002/diff/1/mojo/services/html_viewer/we...
mojo/services/html_viewer/websockethandle_impl.cc:122: // |handle_| can be
deleted here.
On 2014/09/05 18:54:15, darin wrote:
> hmm, this comment is a bit fishy since |this| is already deleted. maybe the
> comment should say "handle" instead of "handle_"? ditto for the others?

Done.

[Matt Perry, 2014-09-05 19:49:12]

The CQ bit was checked by mpcomplete@chromium.org

[commit-bot: I haz the power, 2014-09-05 19:50:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/540683002/20001

[commit-bot: I haz the power, 2014-09-05 21:59:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-05 21:59:42]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Matt Perry, 2014-09-08 19:59:42]

The CQ bit was checked by mpcomplete@chromium.org

[commit-bot: I haz the power, 2014-09-08 20:01:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/540683002/20001

[Matt Perry, 2014-09-08 20:01:13]

The CQ bit was unchecked by mpcomplete@chromium.org

[Matt Perry, 2014-09-08 20:01:28]

The CQ bit was checked by mpcomplete@chromium.org

[commit-bot: I haz the power, 2014-09-08 20:02:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/540683002/40001

[commit-bot: I haz the power, 2014-09-08 22:05:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-08 22:05:11]

Exceeded time limit waiting for builds to trigger.

[Matt Perry, 2014-09-08 22:09:02]

The CQ bit was checked by mpcomplete@chromium.org

[commit-bot: I haz the power, 2014-09-08 22:10:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/540683002/40001

[commit-bot: I haz the power, 2014-09-08 22:49:21]

Committed patchset #3 (id:40001) as b7c14d7833bbf0ab95c7a72db95a79e88e744cf7

[commit-bot: I haz the power, 2014-09-10 03:48:38]

Patchset 3 (id:??) landed as
https://crrev.com/2cbe08dab14cb1f72f3ec478d52941d0bca2fa55
Cr-Commit-Position: refs/heads/master@{#293801}