Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 540673003: Add more browser tests for Kiosk update from usb stick. (Closed)

Created:
6 years, 3 months ago by jennyz
Modified:
6 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add more browser tests for Kiosk update from usb stick. Review URL: https://codereview.chromium.org/509253003 BUG=410611 Committed: https://crrev.com/9b2f59dc4294ea90ae3840ae1ab281eb6229b688 Cr-Commit-Position: refs/heads/master@{#293567}

Patch Set 1 #

Patch Set 2 : Remove TestObsesrver. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -25 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_manager.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager_observer.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_external_updater.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_external_updater.cc View 1 4 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 8 chunks +181 lines, -14 lines 0 comments Download
D chrome/test/data/chromeos/app_mode/external_update/ajoggoflpgplnnjkjamcmbepjdjdnpdp-2.0.0.crx View Binary file 0 comments Download
A + chrome/test/data/chromeos/app_mode/external_update/bad_crx/ajoggoflpgplnnjkjamcmbepjdjdnpdp-2.0.0.crx View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/chromeos/app_mode/external_update/bad_crx/external_update.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/chromeos/app_mode/external_update/bad_manifest/ajoggoflpgplnnjkjamcmbepjdjdnpdp-2.0.0.crx View Binary file 0 comments Download
A + chrome/test/data/chromeos/app_mode/external_update/bad_manifest/external_update.json View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/chromeos/app_mode/external_update/external_update.json View 1 chunk +0 lines, -9 lines 0 comments Download
A + chrome/test/data/chromeos/app_mode/external_update/lower_app_version/ajoggoflpgplnnjkjamcmbepjdjdnpdp-1.0.0.crx View Binary file 0 comments Download
A + chrome/test/data/chromeos/app_mode/external_update/lower_app_version/external_update.json View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/test/data/chromeos/app_mode/external_update/lower_crx_version/ajoggoflpgplnnjkjamcmbepjdjdnpdp-3.0.0.crx View Binary file 0 comments Download
A + chrome/test/data/chromeos/app_mode/external_update/lower_crx_version/external_update.json View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/test/data/chromeos/app_mode/external_update/no_manifest/ajoggoflpgplnnjkjamcmbepjdjdnpdp-2.0.0.crx View Binary file 0 comments Download
A + chrome/test/data/chromeos/app_mode/external_update/update_pass/ajoggoflpgplnnjkjamcmbepjdjdnpdp-2.0.0.crx View Binary file 0 comments Download
A + chrome/test/data/chromeos/app_mode/external_update/update_pass/external_update.json View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
jennyz
6 years, 3 months ago (2014-09-04 00:10:13 UTC) #2
xiyuan
Can we get rid of KioskExternalUpdater::TestObserver and wire the update complete event as part os ...
6 years, 3 months ago (2014-09-04 03:57:02 UTC) #3
jennyz
On 2014/09/04 03:57:02, xiyuan wrote: > Can we get rid of KioskExternalUpdater::TestObserver and wire the ...
6 years, 3 months ago (2014-09-04 19:35:29 UTC) #4
jennyz
6 years, 3 months ago (2014-09-04 19:35:34 UTC) #5
xiyuan
LGTM Thank you for adding more tests!
6 years, 3 months ago (2014-09-04 19:49:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/540673003/20001
6 years, 3 months ago (2014-09-04 20:46:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/540673003/20001
6 years, 3 months ago (2014-09-04 23:06:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/10384)
6 years, 3 months ago (2014-09-05 02:47:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/540673003/20001
6 years, 3 months ago (2014-09-05 16:35:18 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b6941950130c3f063839ba6118717cc0d5251c05
6 years, 3 months ago (2014-09-05 19:32:56 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:41:08 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b2f59dc4294ea90ae3840ae1ab281eb6229b688
Cr-Commit-Position: refs/heads/master@{#293567}

Powered by Google App Engine
This is Rietveld 408576698