Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 540663002: cc: Don't require low res to activate for shared ready-to-draw tiles. (Closed)

Created:
6 years, 3 months ago by danakj
Modified:
6 years, 3 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Don't require low res to activate for shared ready-to-draw tiles. When a tile is shared (no invalidation) and is being drawn on the active tree (ready-to-draw), then that tile is not marked as required for activation since activating it can't cause a bad-resolution flash. However, we also would also say that "twin_had_missing_tile" in this scenario, which causes us to mark low-res tilings as required. But this is a bug since the tile is not missing in this case, and we do not need low res to fill it in. Instead, check to see if the active tree's tile is /not/ ready-to-draw. When that is the case, the active tile is not being drawn and is actually missing. Then a low res tile should be required if the active tree is showing a low res tile in the same place. For perf tests without scrolling (ie pages that just update in place without input), this fixes us to never require low res tiles to activate, since we won't show them. R=enne, vmpstr BUG=407121 Committed: https://crrev.com/bc80fa3586c3a379c367972e22b97304632641b8 Cr-Commit-Position: refs/heads/master@{#293262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -9 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 2 chunks +50 lines, -4 lines 0 comments Download
M cc/test/fake_picture_layer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_picture_layer_impl.cc View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
danakj
6 years, 3 months ago (2014-09-03 23:44:51 UTC) #1
enne (OOO)
lgtm
6 years, 3 months ago (2014-09-03 23:51:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/540663002/1
6 years, 3 months ago (2014-09-03 23:54:45 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1909)
6 years, 3 months ago (2014-09-04 02:33:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/540663002/1
6 years, 3 months ago (2014-09-04 04:39:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 42d34e718a2e362c555c473a9c342989447bd0b2
6 years, 3 months ago (2014-09-04 05:03:12 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:29:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc80fa3586c3a379c367972e22b97304632641b8
Cr-Commit-Position: refs/heads/master@{#293262}

Powered by Google App Engine
This is Rietveld 408576698