Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 540643002: Add WindowManager to about:gpu page on Linux/X11 (Closed)

Created:
6 years, 3 months ago by Zhenyao Mo
Modified:
6 years, 3 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add WindowManager to about:gpu page on Linux/X11 BUG=410560 TEST=about:gpu page R=piman@chromium.org,davemoore@chromium.org,sadrul@chromium.org,derat@chromium.org Committed: https://crrev.com/2e8962b09953dcd93d475120561b414b1749ef85 Cr-Commit-Position: refs/heads/master@{#293322}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -32 lines) Patch
M content/browser/gpu/gpu_internals_ui.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M ui/base/x/x11_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/x/x11_util.cc View 3 chunks +39 lines, -32 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Zhenyao Mo
Please review.
6 years, 3 months ago (2014-09-03 22:56:30 UTC) #1
piman
https://codereview.chromium.org/540643002/diff/1/content/browser/gpu/gpu_internals_ui.cc File content/browser/gpu/gpu_internals_ui.cc (right): https://codereview.chromium.org/540643002/diff/1/content/browser/gpu/gpu_internals_ui.cc#newcode37 content/browser/gpu/gpu_internals_ui.cc:37: #if defined(OS_LINUX) && defined(USE_X11)
6 years, 3 months ago (2014-09-03 23:21:58 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/540643002/diff/1/content/browser/gpu/gpu_internals_ui.cc File content/browser/gpu/gpu_internals_ui.cc (right): https://codereview.chromium.org/540643002/diff/1/content/browser/gpu/gpu_internals_ui.cc#newcode37 content/browser/gpu/gpu_internals_ui.cc:37: #if defined(OS_LINUX) On 2014/09/03 23:21:58, piman (OOO) wrote: > ...
6 years, 3 months ago (2014-09-04 00:03:57 UTC) #3
piman
lgtm
6 years, 3 months ago (2014-09-04 00:17:29 UTC) #4
Ken Russell (switch to Gerrit)
LGTM too.
6 years, 3 months ago (2014-09-04 00:59:08 UTC) #6
sadrul
lgtm
6 years, 3 months ago (2014-09-04 02:40:43 UTC) #7
Daniel Erat
lgtm
6 years, 3 months ago (2014-09-04 14:41:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/540643002/20001
6 years, 3 months ago (2014-09-04 17:50:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3a7c88e0391005c7ae91f81b01195203ea4fd6c0
6 years, 3 months ago (2014-09-04 19:22:52 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:32:13 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2e8962b09953dcd93d475120561b414b1749ef85
Cr-Commit-Position: refs/heads/master@{#293322}

Powered by Google App Engine
This is Rietveld 408576698