Fix compositor-touch-hit-rects.html

Fix compositor-touch-hit-rects.html

Test do not run, because "return" is not allowed at top level
(syntax error).

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181550

[eustas, 2014-09-04 07:58:02]

eustas@chromium.org changed reviewers:
+ leviw@chromium.org, rbyers@chromium.org

[Rick Byers, 2014-09-06 00:17:29]

Thanks!  Note that compositing should be enabled in all chromium cases, so this
path shouldn't get hit (the test is indeed running/passing on the blink linux
bots).  But I agree the failure mode is busted here.

LGTM with nit

https://codereview.chromium.org/540613004/diff/1/LayoutTests/perf/compositor-...
File LayoutTests/perf/compositor-touch-hit-rects.html (right):

https://codereview.chromium.org/540613004/diff/1/LayoutTests/perf/compositor-...
LayoutTests/perf/compositor-touch-hit-rects.html:89: if (window.internals) {
If you're going to wrap this all in a function, then please update the code to
follow the pattern consistently instead of relying on else.  Eg:
if (!windows.internals) {
  log("WARNING - missing windows.internals, can't verify hit testing is
enabled.");
  return;
}

[eustas, 2014-09-08 05:38:51]

https://codereview.chromium.org/540613004/diff/1/LayoutTests/perf/compositor-...
File LayoutTests/perf/compositor-touch-hit-rects.html (right):

https://codereview.chromium.org/540613004/diff/1/LayoutTests/perf/compositor-...
LayoutTests/perf/compositor-touch-hit-rects.html:89: if (window.internals) {
On 2014/09/06 00:17:29, Rick Byers wrote:
> If you're going to wrap this all in a function, then please update the code to
> follow the pattern consistently instead of relying on else.  Eg:
> if (!windows.internals) {
>   log("WARNING - missing windows.internals, can't verify hit testing is
> enabled.");
>   return;
> }

Done. Also fixed log function.

[eustas, 2014-09-08 05:39:19]

The CQ bit was checked by eustas@chromium.org

[commit-bot: I haz the power, 2014-09-08 05:39:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eustas@chromium.org/540613004/20001

[commit-bot: I haz the power, 2014-09-08 09:08:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-08 09:08:16]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/25974)

[eustas, 2014-09-08 09:12:05]

The CQ bit was checked by eustas@chromium.org

[commit-bot: I haz the power, 2014-09-08 09:12:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eustas@chromium.org/540613004/20001

[commit-bot: I haz the power, 2014-09-08 09:44:49]

Committed patchset #2 (id:20001) as 181550