Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 540593002: Use scoped_refptr<SingleThreadTaskRunner> when initializing ProxyConfigService (Closed)

Created:
6 years, 3 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_refptr<SingleThreadTaskRunner> when initializing ProxyConfigService Previously MessageLoop was used to pass reference to the FILE thread to ProxyConfigServiceLinux. Changeed it to use SingleThreadTaskRunner. Also for other thread the task runners were passed as raw pointers. Changed it to use scoped_refptr<> instead. TBR=jochen@chromium.org Committed: https://crrev.com/3f923064c11c69f13a7aba56dce6620a33166c94 Cr-Commit-Position: refs/heads/master@{#293395}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -114 lines) Patch
M chrome/browser/net/proxy_service_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/net/service_url_request_context_getter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_android.h View 2 chunks +7 lines, -5 lines 0 comments Download
M net/proxy/proxy_config_service_android.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M net/proxy/proxy_config_service_linux.h View 6 chunks +20 lines, -17 lines 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 1 2 18 chunks +59 lines, -50 lines 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 1 4 chunks +12 lines, -9 lines 0 comments Download
M net/proxy/proxy_config_service_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_service.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/proxy/proxy_service.cc View 2 chunks +9 lines, -15 lines 0 comments Download
M net/tools/net_watcher/net_watcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
Sergey Ulanov
6 years, 3 months ago (2014-09-03 22:33:04 UTC) #2
mmenke
I'll take a look tomorrow, but is there a reason not to use SequencedTaskRunner?
6 years, 3 months ago (2014-09-03 22:56:20 UTC) #3
Sergey Ulanov
On 2014/09/03 22:56:20, mmenke wrote: > I'll take a look tomorrow, but is there a ...
6 years, 3 months ago (2014-09-03 23:19:23 UTC) #4
mmenke
On 2014/09/03 23:19:23, Sergey Ulanov wrote: > On 2014/09/03 22:56:20, mmenke wrote: > > I'll ...
6 years, 3 months ago (2014-09-04 16:14:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/540593002/60001
6 years, 3 months ago (2014-09-04 22:05:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8861)
6 years, 3 months ago (2014-09-05 00:16:14 UTC) #9
Sergey Ulanov
+jochen@ in TBR for no-op changes in src/content and src/chrome
6 years, 3 months ago (2014-09-05 00:25:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/540593002/60001
6 years, 3 months ago (2014-09-05 00:29:53 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001) as a0b197593df55fb24e37d23fa78ee3a5cd57ed1f
6 years, 3 months ago (2014-09-05 01:42:50 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:35:17 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3f923064c11c69f13a7aba56dce6620a33166c94
Cr-Commit-Position: refs/heads/master@{#293395}

Powered by Google App Engine
This is Rietveld 408576698