chrome/browser/resources/chromeos/chromevox/common/key_sequence.js - Issue 540583002: Fix the ChromeVox "sticky key" (pressing Search twice).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/key_sequence.js

Issue 540583002: Fix the ChromeVox "sticky key" (pressing Search twice). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simpler fix Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/chromeos/chromevox/common/key_sequence.js

diff --git a/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js b/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js

index 90647ddd42e141144ef1ff2d3057aeeb1d32d847..5759399cb27429d7547921a204aa34e9db42f605 100644

--- a/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js

+++ b/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js

@@ -387,8 +387,7 @@ cvox.KeySequence.prototype.isKeyModifierActive = function(keyEvent, modifier) {

return (keyEvent.shiftKey || (keyEvent.keyCode == 16));

break;

case 'metaKey':

- return (keyEvent.metaKey ||

- (!cvox.ChromeVox.isChromeOS && keyEvent.keyCode == 91));

+ return (keyEvent.metaKey || (keyEvent.keyCode == 91));

break;

case 'searchKeyHeld':

return ((cvox.ChromeVox.isChromeOS && keyEvent.keyCode == 91) ||

« no previous file with comments | « no previous file | no next file » | no next file with comments »