Fix the ChromeVox "sticky key" (pressing Search twice).

chrome/browser/resources/chromeos/chromevox/common/key_sequence.js

Index: chrome/browser/resources/chromeos/chromevox/common/key_sequence.js
diff --git a/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js b/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js
index 90647ddd42e141144ef1ff2d3057aeeb1d32d847..da5fa913fdbb136f5d4c6045f37f2dc5eacbc930 100644
--- a/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js
+++ b/chrome/browser/resources/chromeos/chromevox/common/key_sequence.js
@@ -387,8 +387,8 @@ cvox.KeySequence.prototype.isKeyModifierActive = function(keyEvent, modifier) {
       return (keyEvent.shiftKey || (keyEvent.keyCode == 16));
       break;
     case 'metaKey':
-      return (keyEvent.metaKey ||
-          (!cvox.ChromeVox.isChromeOS && keyEvent.keyCode == 91));
+      return (!cvox.ChromeVox.isChromeOS &&

[David Tseng, 2014/09/04 15:33:33]

This line of fixes worries me and seems to say that it's a poor choice to
simulate touch exploration as the "meta" key. This will probably have some
negative consequences for the way we want to do commands in ChromeVox next for
example.

As for this temp fix, why not just unify this with the other todo'ed fix you
have and just strip metakey entirely when on Chrome OS (just earlier in the
event processing)?

+          (keyEvent.metaKey || keyEvent.keyCode == 91));
       break;
     case 'searchKeyHeld':
       return ((cvox.ChromeVox.isChromeOS && keyEvent.keyCode == 91) ||