Fix the ChromeVox "sticky key" (pressing Search twice).

chrome/browser/resources/chromeos/chromevox/common/key_sequence.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview A JavaScript class that represents a sequence of keys entered
  * by the user.
  */
 
 
@@ skipping 369 matching lines @@
     case 'ctrlKey':
       return (keyEvent.ctrlKey || keyEvent.keyCode == 17);
       break;
     case 'altKey':
       return (keyEvent.altKey || (keyEvent.keyCode == 18));
       break;
     case 'shiftKey':
       return (keyEvent.shiftKey || (keyEvent.keyCode == 16));
       break;
     case 'metaKey':
-      return (keyEvent.metaKey ||
-          (!cvox.ChromeVox.isChromeOS && keyEvent.keyCode == 91));
+      return (!cvox.ChromeVox.isChromeOS &&

[David Tseng, 2014/09/04 15:33:33]

This line of fixes worries me and seems to say that it's a poor choice to
simulate touch exploration as the "meta" key. This will probably have some
negative consequences for the way we want to do commands in ChromeVox next for
example.

As for this temp fix, why not just unify this with the other todo'ed fix you
have and just strip metakey entirely when on Chrome OS (just earlier in the
event processing)?

+          (keyEvent.metaKey || keyEvent.keyCode == 91));
       break;
     case 'searchKeyHeld':
       return ((cvox.ChromeVox.isChromeOS && keyEvent.keyCode == 91) ||
           keyEvent['searchKeyHeld']);
       break;
   }
   return false;
 };
 
 /**
@@ skipping 219 matching lines @@
       break;
     case 122:  // F11
       evt['keyCode'] = 189;  // Hyphen.
       break;
     case 123:  // F12
       evt['keyCode'] = 187;  // Equals.
       break;
   }
   return evt;
 };