Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 540543002: Switch Layer Hoisting over to SkRecord backend (Closed)

Created:
6 years, 3 months ago by robertphillips
Modified:
6 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -382 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +1 line, -0 lines 0 comments Download
D src/core/SkPictureRangePlayback.h View 1 chunk +0 lines, -41 lines 0 comments Download
D src/core/SkPictureRangePlayback.cpp View 1 chunk +0 lines, -57 lines 0 comments Download
D src/core/SkPictureReplacementPlayback.h View 1 chunk +0 lines, -86 lines 0 comments Download
D src/core/SkPictureReplacementPlayback.cpp View 1 chunk +0 lines, -171 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 4 chunks +8 lines, -12 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 6 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
robertphillips
6 years, 3 months ago (2014-09-03 21:28:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/540543002/1
6 years, 3 months ago (2014-09-04 13:12:35 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-04 13:12:36 UTC) #5
commit-bot: I haz the power
Presubmit check for 540543002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 3 months ago (2014-09-04 13:12:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/540543002/1
6 years, 3 months ago (2014-09-04 13:17:35 UTC) #9
commit-bot: I haz the power
This issue passed the CQ. To commit it, remove "COMMIT=false" from the description and try ...
6 years, 3 months ago (2014-09-04 13:25:56 UTC) #10
bsalomon
lgtm
6 years, 3 months ago (2014-09-04 14:23:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/540543002/1
6 years, 3 months ago (2014-09-04 14:24:05 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-04 14:24:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 274b4ba6bde67bb8b6d8f1721ef5d6d4294f2aa8

Powered by Google App Engine
This is Rietveld 408576698