LayoutTests/fast/css/invalidation/link-pseudo.html - Issue 540533004: Use style invalidation for more pseudo classes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/invalidation/link-pseudo.html

Issue 540533004: Use style invalidation for more pseudo classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css/invalidation/indeterminate-pseudo-expected.txt ('k') | LayoutTests/fast/css/invalidation/link-pseudo-expected.txt » ('j') | Source/core/css/RuleFeature.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/js-test.js"></script>

	3 <script>

	4 if (window.testRunner)

	5 testRunner.keepWebHistory();

	6 </script>

	7 <style>

	8 :link, :visited { all: initial }

	9 #match { background-color: red }

	10 :link #match { background-color: green }

	11 #link + div { color: pink }

	12 </style>

	13 <a id="link">

	14 <span></span>

	15 <span>

	16 <span></span>

	17 <span id="match"></span>

	18 </span>

	19 </a>

	20 <div>

	21 <div></div>

	22 <div></div>

	23 <div></div>

	24 <div></div>

	25 </div>

	26 <script>

	27 description("Use descendant invalidation set for :link pseudo class.")

	28

	29 var red = "rgb(255, 0, 0)";

	30 var green = "rgb(0, 128, 0)";

	31

	32 if (window.internals)

	33 shouldBe("internals.computedStyleIncludingVisitedInfo(match).backgroundColor ", "red");

	34

	35 link.offsetTop; // Force recalc.
	esprehn 2014/09/19 04:55:17 I often use getComputedStyle(link).color; to avoid I often use getComputedStyle(link).color; to avoid also causing a layout so your test is more targeted. rune 2014/09/23 12:23:16 getComputedStyle doesn't recalc/layout enough to m Show quoted text On 2014/09/19 04:55:17, esprehn wrote: > I often use getComputedStyle(link).color; to avoid also causing a layout so your > test is more targeted. getComputedStyle doesn't recalc/layout enough to make the updateStyleAnd... below be unaffected by the shouldBe() output above.
	36 link.href = "not-visited.html";

	37

	38 if (window.internals) {

	39 // Ideally, the affected element count should be 2, but there is a _insideLi nk that

	40 // causes inheritance to recalc all elements inside <a>.

	41 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "5");

	42 shouldBe("internals.computedStyleIncludingVisitedInfo(match).backgroundColor ", "green");

	43 }

	44

	45 </script>

OLD	NEW