Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 54053008: Re-enable runtime badging of browser windows. (Closed)

Created:
7 years, 1 month ago by calamity
Modified:
7 years, 1 month ago
CC:
chromium-reviews, tfarina, Alexei Svitkine (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Re-enable runtime badging of browser windows. This CL fixes an issue with the profile icon not showing up if the user has pinned the default chrome shortcut to the taskbar. Using the runtime badging on top of the taskbar icon's badge causes the badge to look slightly darker around the edges at runtime. BUG=313800 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233433

Patch Set 1 #

Patch Set 2 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 1 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
calamity
7 years, 1 month ago (2013-11-05 02:36:00 UTC) #1
sky
LGTM
7 years, 1 month ago (2013-11-05 04:12:24 UTC) #2
gab
I guess I'm fine with this; it's preferable to always have an icon than to ...
7 years, 1 month ago (2013-11-05 16:45:25 UTC) #3
Alexei Svitkine (slow)
LGTM can you add a TODO / crbug link referring to the plan to take ...
7 years, 1 month ago (2013-11-05 17:55:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/54053008/70001
7 years, 1 month ago (2013-11-06 01:14:10 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-06 01:47:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/54053008/70001
7 years, 1 month ago (2013-11-06 08:58:46 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=220484
7 years, 1 month ago (2013-11-06 11:08:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/54053008/70001
7 years, 1 month ago (2013-11-06 22:47:06 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 00:30:49 UTC) #10
Message was sent while issue was closed.
Change committed as 233433

Powered by Google App Engine
This is Rietveld 408576698