Update media tests to unprefixed MSE API.

Update media tests to unprefixed MSE API.

BUG=307107
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233420

[shadi, 2013-11-05 01:52:35]

This updates the common JS code to use unprefixed MSE API. PTAL

[xhwang, 2013-11-05 02:18:26]

lgtm % nits which also apply to the other two files.

https://codereview.chromium.org/54053007/diff/1/chrome/test/data/media/media_...
File chrome/test/data/media/media_source_utils.js (right):

https://codereview.chromium.org/54053007/diff/1/chrome/test/data/media/media_...
chrome/test/data/media/media_source_utils.js:47: var eventHandler = function(e)
{
s/eventHandler/onUpdateEnd?

https://codereview.chromium.org/54053007/diff/1/chrome/test/data/media/media_...
chrome/test/data/media/media_source_utils.js:48: console.log('Appending to
buffer ' + mediaFile);
Should this be "Appending buffer from"?

https://codereview.chromium.org/54053007/diff/1/chrome/test/data/media/mse_co...
File chrome/test/data/media/mse_config_change.html (right):

https://codereview.chromium.org/54053007/diff/1/chrome/test/data/media/mse_co...
chrome/test/data/media/mse_config_change.html:43: var eventHandler = function(e)
{
ditto about naming

[shadi, 2013-11-05 18:52:17]

Thanks!

acolwell@: any comments?

https://codereview.chromium.org/54053007/diff/1/chrome/test/data/media/media_...
File chrome/test/data/media/media_source_utils.js (right):

https://codereview.chromium.org/54053007/diff/1/chrome/test/data/media/media_...
chrome/test/data/media/media_source_utils.js:47: var eventHandler = function(e)
{
On 2013/11/05 02:18:26, xhwang wrote:
> s/eventHandler/onUpdateEnd?

Done.

https://codereview.chromium.org/54053007/diff/1/chrome/test/data/media/media_...
chrome/test/data/media/media_source_utils.js:48: console.log('Appending to
buffer ' + mediaFile);
On 2013/11/05 02:18:26, xhwang wrote:
> Should this be "Appending buffer from"?

Done.

https://codereview.chromium.org/54053007/diff/1/chrome/test/data/media/mse_co...
File chrome/test/data/media/mse_config_change.html (right):

https://codereview.chromium.org/54053007/diff/1/chrome/test/data/media/mse_co...
chrome/test/data/media/mse_config_change.html:43: var eventHandler = function(e)
{
On 2013/11/05 02:18:26, xhwang wrote:
> ditto about naming

Done.

[acolwell GONE FROM CHROMIUM, 2013-11-05 18:52:41]

lgtm % xhwang's comments on naming.

Is there really no way to share code between chrome & content tests? It seems
kind of lame that you have to have duplicate files.

[shadi, 2013-11-05 18:57:08]

I think the right way is to have a gyp setting to copy content media data
to chrome media data, or vice versa. Or maybe there is a way to override
default chrome browser tests's web server to content's data folder...WDYT?
I'll try to look into it separately.


On Tue, Nov 5, 2013 at 10:52 AM, <acolwell@chromium.org> wrote:

> lgtm % xhwang's comments on naming.
>
> Is there really no way to share code between chrome & content tests? It
> seems
> kind of lame that you have to have duplicate files.
>
> https://codereview.chromium.org/54053007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-11-05 20:58:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shadi@chromium.org/54053007/70001

[commit-bot: I haz the power, 2013-11-05 22:39:44]

Retried try job too often on linux_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-06 18:21:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shadi@chromium.org/54053007/70001

[commit-bot: I haz the power, 2013-11-06 20:20:00]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-06 21:31:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shadi@chromium.org/54053007/70001

[commit-bot: I haz the power, 2013-11-06 23:45:04]

Change committed as 233420