Move weborigin/ under platform/ so that it may someday call platform APIs

This is a precursor for implementing better checks when setting document.domain.

This folds weborigin/ back under platform/ to allow it to call Platform APIs. Weborigin was originally split off to allow it to be called in other places; turns out this was not necessary.

The tests in the weborigin_unittests target are now folded back into blink_platform_unittests. The weborigin_unittests will no longer exist.

BUG=307407
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161946

[Tom Sepez, 2013-11-05 00:30:46]

This will need to be broken into smaller pieces, but check that I've hit
everything ...

[abarth-chromium, 2013-11-05 06:46:29]

Looks about right.  Do we need to teach the buildbots not to run
weborigin_unittests anymore?

https://codereview.chromium.org/54053006/diff/1/Source/platform/weborigin/DEPS
File Source/platform/weborigin/DEPS (right):

https://codereview.chromium.org/54053006/diff/1/Source/platform/weborigin/DEP...
Source/platform/weborigin/DEPS:3: ]
This DEPS file shouldn't be needed anymore.

[abarth-chromium, 2013-11-05 06:47:27]

https://codereview.chromium.org/54053006/diff/1/public/platform/Platform.h
File public/platform/Platform.h (right):

https://codereview.chromium.org/54053006/diff/1/public/platform/Platform.h#ne...
public/platform/Platform.h:342: 
Two blank lines between sections pls.

[jamesr, 2013-11-05 06:54:08]

Can I ask why weborigin is being moved out of the top level?

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Tom Sepez, 2013-11-05 18:08:57]

On 2013/11/05 06:54:08, jamesr wrote:
> Can I ask why weborigin is being moved out of the top level?
> 
Plumbing. In order to make weborigin/OriginAccessEntry.cpp behave more in-line
with the specs, it needs support from chromium's domain_controlled_registry
code. To call that code, it needs to have a new platform API. To call that
platform API, it can't be off by itself in the weborigin component.

[Tom Sepez, 2013-11-07 01:14:28]

Reviewers, please review.  I've separated out the rename from the other parts of
the previous CL.  

Once this is good to go, I can file a bug to get the weborigin_unittests removed
from the bots.

[abarth-chromium, 2013-11-07 02:41:37]

Can you update the description?  You don't appear to be introducing the new
interface in this CL (which is a good thing!).  Also, it would be good to
include some more of the explanation you have in the comments in the
description.

I spot checked the meat of the changes, and this LGTM.  The only part I'm not
sure about is removing the weborigin_unittests from all.gyp.  We definitely want
to do that, but I'm worried that it will break some buildbots.

[Tom Sepez, 2013-11-07 17:59:50]

On 2013/11/07 02:41:37, abarth wrote:
> Can you update the description?  You don't appear to be introducing the new
> interface in this CL (which is a good thing!).  Also, it would be good to
> include some more of the explanation you have in the comments in the
> description.
> 
Done.

> I spot checked the meat of the changes, and this LGTM.  The only part I'm not
> sure about is removing the weborigin_unittests from all.gyp.  We definitely
want
> to do that, but I'm worried that it will break some buildbots.
Will wait on https://code.google.com/p/chromium/issues/detail?id=316246 before
landing.

[commit-bot: I haz the power, 2013-11-12 22:22:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/54053006/520001

[commit-bot: I haz the power, 2013-11-12 23:38:20]

Retried try job too often on win_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-11-13 18:22:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/54053006/660001

[commit-bot: I haz the power, 2013-11-13 20:47:03]

Change committed as 161946