Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 540503003: Fix TrackRunIterator to generate a parse error when it encounters a reserved dependency value. (Closed)

Created:
6 years, 3 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix TrackRunIterator to generate a parse error when it encounters a reserved dependency value. Replaces a CHECK() with a parser error when reserved "depends on" values appear in the sample flags. BUG=410404 TESTS=TrackRunIteratorTest.SampleInfoTest_ReservedInSampleFlags, TrackRunIteratorTest.SampleInfoTest_ReservedInDefaultSampleFlags Committed: https://crrev.com/272aec140085ca6ad9cdc0a505ca93c494e34776 Cr-Commit-Position: refs/heads/master@{#293596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
M media/formats/mp4/track_run_iterator.cc View 3 chunks +13 lines, -5 lines 0 comments Download
M media/formats/mp4/track_run_iterator_unittest.cc View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
acolwell GONE FROM CHROMIUM
6 years, 3 months ago (2014-09-03 20:14:54 UTC) #2
scherkus (not reviewing)
OOC did you mean bug 408552 or bug 410404? also as an FYI YouTube seems ...
6 years, 3 months ago (2014-09-03 22:41:45 UTC) #3
acolwell GONE FROM CHROMIUM
On 2014/09/03 22:41:45, scherkus wrote: > OOC did you mean bug 408552 or bug 410404? ...
6 years, 3 months ago (2014-09-03 23:19:33 UTC) #4
scherkus (not reviewing)
lgtm
6 years, 3 months ago (2014-09-03 23:20:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/540503003/1
6 years, 3 months ago (2014-09-03 23:24:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/1891)
6 years, 3 months ago (2014-09-04 02:27:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/540503003/1
6 years, 3 months ago (2014-09-06 00:00:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as b44ec086026c9b44ece39a554638159f0b5562bc
6 years, 3 months ago (2014-09-06 00:46:57 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/272aec140085ca6ad9cdc0a505ca93c494e34776
Cr-Commit-Position: refs/heads/master@{#293596}

Powered by Google App Engine
This is Rietveld 408576698