Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 540493002: [chromium] Remove XMLViewer.js/css post blink-in-js migration of XML tree viewer. (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chromium] Remove XMLViewer.js/css post blink-in-js migration of XML tree viewer. CL, https://codereview.chromium.org/479753003, migrated the usage of XML tree viewer to be implemented in blink-in-js. Post the migration, the files XMLViewer.js/css are no longer used by any native code directly and hence should be removed. Subsequent blink side CL would remove these files from the repository permanently. TBR=jochen@chromium.org NOTRY=true Committed: https://crrev.com/9985c16ee7925937f69c9e320ba8409e0ac729c5 Cr-Commit-Position: refs/heads/master@{#293303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/child/blink_platform_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
vivekg
PTAL. We should commit this once the blink roll crosses 181328.
6 years, 3 months ago (2014-09-03 18:56:58 UTC) #2
vivekg
6 years, 3 months ago (2014-09-04 08:03:25 UTC) #4
haraken
LGTM
6 years, 3 months ago (2014-09-04 08:05:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/540493002/1
6 years, 3 months ago (2014-09-04 08:09:35 UTC) #7
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-04 08:41:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/2082)
6 years, 3 months ago (2014-09-04 08:56:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/540493002/1
6 years, 3 months ago (2014-09-04 10:43:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/540493002/1
6 years, 3 months ago (2014-09-04 15:23:47 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as 22b83e73f421506e024af89844da4d0a36a9dabe
6 years, 3 months ago (2014-09-04 15:26:41 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:31:34 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9985c16ee7925937f69c9e320ba8409e0ac729c5
Cr-Commit-Position: refs/heads/master@{#293303}

Powered by Google App Engine
This is Rietveld 408576698