chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h - Issue 540483002: Fix regression in showing bookmark star when an extension should override it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h

Issue 540483002: Fix regression in showing bookmark star when an extension should override it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Peter's Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/location_bar_controller.cc ('k') | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm » ('j') | chrome/browser/ui/location_bar/location_bar_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h

diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h

index cb49aaddbe5b6cc8128cc7e98b16145296a90656..6948bd6163d69f8c6acf2f0cc53bedd50ac1d3b7 100644

--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h

+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h

@@ -67,6 +67,7 @@ class LocationBarViewMac : public LocationBar,

virtual void UpdateManagePasswordsIconAndBubble() OVERRIDE;

virtual void UpdatePageActions() OVERRIDE;

virtual void InvalidatePageActions() OVERRIDE;

+ virtual void UpdateBookmarkStarVisibility() OVERRIDE;

virtual bool ShowPageActionPopup(const extensions::Extension* extension,

bool grant_active_tab) OVERRIDE;

virtual void UpdateOpenPDFInReaderPrompt() OVERRIDE;

@@ -213,9 +214,6 @@ class LocationBarViewMac : public LocationBar,

// Returns whether any updates were made.

bool UpdateZoomDecoration();

- // Ensures the star decoration is visible or hidden, as required.

- void UpdateStarDecorationVisibility();

// Updates the voice search decoration. Returns true if the visible state was

// changed.

bool UpdateMicSearchDecorationVisibility();