Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: chrome/browser/ui/location_bar/location_bar.h

Issue 540483002: Fix regression in showing bookmark star when an extension should override it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_ 5 #ifndef CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_
6 #define CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_ 6 #define CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_
7 7
8 #include "content/public/common/page_transition_types.h" 8 #include "content/public/common/page_transition_types.h"
9 #include "ui/base/window_open_disposition.h" 9 #include "ui/base/window_open_disposition.h"
10 #include "url/gurl.h" 10 #include "url/gurl.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 51
52 // Updates the state of the images showing the content settings status. 52 // Updates the state of the images showing the content settings status.
53 virtual void UpdateContentSettingsIcons() = 0; 53 virtual void UpdateContentSettingsIcons() = 0;
54 54
55 // Updates the password icon and pops up a bubble from the icon if needed. 55 // Updates the password icon and pops up a bubble from the icon if needed.
56 virtual void UpdateManagePasswordsIconAndBubble() = 0; 56 virtual void UpdateManagePasswordsIconAndBubble() = 0;
57 57
58 // Updates the state of the page actions. 58 // Updates the state of the page actions.
59 virtual void UpdatePageActions() = 0; 59 virtual void UpdatePageActions() = 0;
60 60
61 // Updates the visibility of the bookmark star.
62 virtual void UpdateBookmarkStarVisibility() = 0;
63
61 // Called when the page-action data needs to be refreshed, e.g. when an 64 // Called when the page-action data needs to be refreshed, e.g. when an
62 // extension is unloaded or crashes. 65 // extension is unloaded or crashes.
63 virtual void InvalidatePageActions() = 0; 66 virtual void InvalidatePageActions() = 0;
64 67
65 // Shows the popup for the given |extension| and, if |grant_active_tab| is 68 // Shows the popup for the given |extension| and, if |grant_active_tab| is
66 // true, grants the extension active tab permissions. 69 // true, grants the extension active tab permissions.
67 // Returns true if a popup was shown. 70 // Returns true if a popup was shown.
68 virtual bool ShowPageActionPopup(const extensions::Extension* extension, 71 virtual bool ShowPageActionPopup(const extensions::Extension* extension,
69 bool grant_active_tab) = 0; 72 bool grant_active_tab) = 0;
70 73
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 virtual void TestPageActionPressed(size_t index) = 0; 124 virtual void TestPageActionPressed(size_t index) = 0;
122 125
123 // Returns whether or not the bookmark star decoration is visible. 126 // Returns whether or not the bookmark star decoration is visible.
124 virtual bool GetBookmarkStarVisibility() = 0; 127 virtual bool GetBookmarkStarVisibility() = 0;
125 128
126 protected: 129 protected:
127 virtual ~LocationBarTesting() {} 130 virtual ~LocationBarTesting() {}
128 }; 131 };
129 132
130 #endif // CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_ 133 #endif // CHROME_BROWSER_UI_LOCATION_BAR_LOCATION_BAR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698