Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 540473002: Mark parsing routines with ENABLE(SVG_FONTS) (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
Reviewers:
pdr., kouhei (in TOK)
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Mark parsing routines with ENABLE(SVG_FONTS) Marking these SVG Fonts specific parsing routines makes it harder to forget to remove them at the time SVG Fonts are removed. BUG=242735 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181340

Patch Set 1 #

Patch Set 2 : Remove gyp change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/svg/SVGParserUtilities.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGParserUtilities.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rwlbuis
PTAL
6 years, 3 months ago (2014-09-03 20:17:22 UTC) #3
kouhei (in TOK)
On 2014/09/03 20:17:22, rwlbuis wrote: > PTAL lgtm
6 years, 3 months ago (2014-09-03 20:19:59 UTC) #4
pdr.
On 2014/09/03 20:19:59, kouhei wrote: > On 2014/09/03 20:17:22, rwlbuis wrote: > > PTAL > ...
6 years, 3 months ago (2014-09-03 20:23:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/540473002/40001
6 years, 3 months ago (2014-09-03 20:24:52 UTC) #7
rwlbuis
On 2014/09/03 20:23:53, pdr wrote: > On 2014/09/03 20:19:59, kouhei wrote: > > On 2014/09/03 ...
6 years, 3 months ago (2014-09-03 20:31:02 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-03 21:36:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as 181340

Powered by Google App Engine
This is Rietveld 408576698