Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 540453003: Get rid of anonymous table* wrappers when they are no longer needed. (Closed)

Created:
6 years, 3 months ago by mstensho (USE GERRIT)
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Get rid of anonymous table* wrappers when they are no longer needed. When a renderer is removed, don't just see if an anonymous parent should be destroyed, but keep looking further up in the ancestry as well. BUG=389129 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182082

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review. Don't special-case on table. #

Patch Set 3 : rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
A LayoutTests/fast/table/remove-anonymous-cell.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/remove-anonymous-cell-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/remove-anonymous-row.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/remove-anonymous-row-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mstensho (USE GERRIT)
6 years, 3 months ago (2014-09-03 20:08:11 UTC) #2
Julien - ping for review
https://codereview.chromium.org/540453003/diff/1/Source/core/rendering/RenderObject.cpp File Source/core/rendering/RenderObject.cpp (right): https://codereview.chromium.org/540453003/diff/1/Source/core/rendering/RenderObject.cpp#newcode2817 Source/core/rendering/RenderObject.cpp:2817: if (destroyRoot != this && !destroyRootParent->isTableCell() && !destroyRootParent->isTableRow() && ...
6 years, 3 months ago (2014-09-08 21:28:49 UTC) #3
mstensho (USE GERRIT)
https://codereview.chromium.org/540453003/diff/1/Source/core/rendering/RenderObject.cpp File Source/core/rendering/RenderObject.cpp (right): https://codereview.chromium.org/540453003/diff/1/Source/core/rendering/RenderObject.cpp#newcode2817 Source/core/rendering/RenderObject.cpp:2817: if (destroyRoot != this && !destroyRootParent->isTableCell() && !destroyRootParent->isTableRow() && ...
6 years, 3 months ago (2014-09-16 13:00:07 UTC) #4
Julien - ping for review
lgtm
6 years, 3 months ago (2014-09-16 17:40:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/540453003/40001
6 years, 3 months ago (2014-09-16 17:41:28 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 18:44:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 182082

Powered by Google App Engine
This is Rietveld 408576698