content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h - Issue 540443002: Enable sync allocation of GpuMemoryBuffers from the browser process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

Issue 540443002: Enable sync allocation of GpuMemoryBuffers from the browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc ('K') | « content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc ('k') | content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc » ('j') | content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h b/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

index a7868c15ea39a36ee55f5f071ae9ff88d811e465..b562034e12c397abeb6eef898a1b6175d9c55c60 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

@@ -24,6 +24,11 @@ class GpuMemoryBufferImplSharedMemory : public GpuMemoryBufferImpl {

base::ProcessHandle child_process,

const AllocationCallback& callback);

+ static void Create(const gfx::Size& size,

reveman 2014/09/09 23:17:54 nit: please order the functions as GpuMemoryBuffer

alexst (slow to review) 2014/09/10 01:57:49 Done.

+ unsigned internalformat,

+ unsigned usage,

+ const CreationCallback& callback);

static bool IsLayoutSupported(const gfx::Size& size, unsigned internalformat);

static bool IsUsageSupported(unsigned usage);

static bool IsConfigurationSupported(const gfx::Size& size,