Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl.h

Issue 540443002: Enable sync allocation of GpuMemoryBuffers from the browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: formatting Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/gpu_memory_buffer_impl.h
diff --git a/content/common/gpu/client/gpu_memory_buffer_impl.h b/content/common/gpu/client/gpu_memory_buffer_impl.h
index e3323f0fed72148f3ab77e984fc67eccfa130307..312e2e2c38a6c3404920c8496131d8f0b2b5dba5 100644
--- a/content/common/gpu/client/gpu_memory_buffer_impl.h
+++ b/content/common/gpu/client/gpu_memory_buffer_impl.h
@@ -17,14 +17,17 @@ class GpuMemoryBufferImpl : public gfx::GpuMemoryBuffer {
public:
typedef base::Callback<void(const gfx::GpuMemoryBufferHandle& handle)>
AllocationCallback;
+ typedef base::Callback<void(scoped_ptr<GpuMemoryBufferImpl> buffer)>
+ CreationCallback;
reveman 2014/09/09 17:18:26 nit: sort these typedefs in the order they are use
alexst (slow to review) 2014/09/09 21:53:57 Done.
virtual ~GpuMemoryBufferImpl();
// Creates a GPU memory buffer instance with |size| and |internalformat| for
// |usage|.
- static scoped_ptr<GpuMemoryBufferImpl> Create(const gfx::Size& size,
- unsigned internalformat,
- unsigned usage);
+ static void Create(const gfx::Size& size,
+ unsigned internalformat,
+ unsigned usage,
+ const CreationCallback& callback);
// Allocates a GPU memory buffer with |size| and |internalformat| for |usage|
// by |child_process| identified by |child_id|. The |handle| returned can be

Powered by Google App Engine
This is Rietveld 408576698