Enable sync allocation of GpuMemoryBuffers from the browser process.

content/common/gpu/client/gpu_memory_buffer_impl_ozone.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/gpu_memory_buffer_impl.h"
 
 #include "content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h"
 #include "content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h"
 
 namespace content {
 
 // static
 scoped_ptr<GpuMemoryBufferImpl> GpuMemoryBufferImpl::Create(
     const gfx::Size& size,
     unsigned internalformat,
     unsigned usage) {
+  if (GpuMemoryBufferImplOzoneNativeBuffer::IsConfigurationSupported(
+          internalformat, usage)) {
+    return GpuMemoryBufferImplOzoneNativeBuffer::
+        AllocateOzoneNativeBufferForBrowser(size, internalformat, usage);

[reveman, 2014/09/04 22:37:24]

Please make it:

scoped_ptr<GpuMemoryBufferImplOzoneNativeBuffer> buffer(
    new GpuMemoryBufferImplOzoneNativeBuffer(size, internalformat));
if (!buffer->Initialize())
  return scoped_ptr<GpuMemoryBufferImpl>();

and adjust GpuMemoryBufferImplOzoneNativeBuffer accordingly. This code should
not really have to be aware of a browser process. All it knows is that it's
initializing an in-process GpuMemoryBufferImpl instance.

If there's a good reason to change this convention then we should change it for
all implementations.

[alexst (slow to review), 2014/09/05 02:04:53]

I see what you meant now, sounds good.

I added usage to Initialize() because it's not stored on GpuMemoryBuffer.
Alternatively we need to plumb it into the constructors for all the types if you
want to keep Initialize argument free.

+  }
   if (GpuMemoryBufferImplSharedMemory::IsConfigurationSupported(
           size, internalformat, usage)) {
     scoped_ptr<GpuMemoryBufferImplSharedMemory> buffer(
         new GpuMemoryBufferImplSharedMemory(size, internalformat));
     if (!buffer->Initialize())
       return scoped_ptr<GpuMemoryBufferImpl>();
 
     return buffer.PassAs<GpuMemoryBufferImpl>();
   }
 
@@ skipping 52 matching lines @@
         return scoped_ptr<GpuMemoryBufferImpl>();
 
       return buffer.PassAs<GpuMemoryBufferImpl>();
     }
     default:
       return scoped_ptr<GpuMemoryBufferImpl>();
   }
 }
 
 }  // namespace content