Remove some duplicate code in quic tests.

Remove some duplicate code in quic tests.
BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238210

[wtc, 2013-11-04 01:58:27]

Patch set 1 LGTM. Thanks!

https://codereview.chromium.org/54043003/diff/1/net/quic/crypto/aes_128_gcm_1...
File net/quic/crypto/aes_128_gcm_12_encrypter_test.cc (right):

https://codereview.chromium.org/54043003/diff/1/net/quic/crypto/aes_128_gcm_1...
net/quic/crypto/aes_128_gcm_12_encrypter_test.cc:263: aad.size() ? aad :
StringPiece(), pt));

I assume you verified that StringPiece() initialized its data member to NULL. No
need to respond to this comment.

https://codereview.chromium.org/54043003/diff/1/net/quic/crypto/channel_id_te...
File net/quic/crypto/channel_id_test.cc (right):

https://codereview.chromium.org/54043003/diff/1/net/quic/crypto/channel_id_te...
net/quic/crypto/channel_id_test.cc:215: EXPECT_EQ(signature.size() / 2,
s.size());

The new tests are weaker than the original tests.

The original tests verify that qx.size() and qy.size(0 are exactly 64/2 (= 32),
and r.size() and s.size() are 64/2 (= 32).

https://codereview.chromium.org/54043003/diff/1/net/quic/test_tools/quic_test...
File net/quic/test_tools/quic_test_utils.cc (right):

https://codereview.chromium.org/54043003/diff/1/net/quic/test_tools/quic_test...
net/quic/test_tools/quic_test_utils.cc:391: *bytes = string();

Nit: would bytes->clear() be better?

https://codereview.chromium.org/54043003/diff/1/net/quic/test_tools/quic_test...
net/quic/test_tools/quic_test_utils.cc:398: *bytes =
string(reinterpret_cast<const char*>(&v[0]), v.size());

Nit: this probably can be a bytes->append() call.

It is s shame we have to copy from a vector to a string.

[eroman, 2013-11-04 19:39:58]

https://codereview.chromium.org/54043003/diff/1/net/quic/crypto/channel_id_te...
File net/quic/crypto/channel_id_test.cc (right):

https://codereview.chromium.org/54043003/diff/1/net/quic/crypto/channel_id_te...
net/quic/crypto/channel_id_test.cc:215: EXPECT_EQ(signature.size() / 2,
s.size());
On 2013/11/04 01:58:27, wtc wrote:
> 
> The new tests are weaker than the original tests.
> 
> The original tests verify that qx.size() and qy.size(0 are exactly 64/2 (=
32),
> and r.size() and s.size() are 64/2 (= 32).

Done.

https://codereview.chromium.org/54043003/diff/1/net/quic/test_tools/quic_test...
File net/quic/test_tools/quic_test_utils.cc (right):

https://codereview.chromium.org/54043003/diff/1/net/quic/test_tools/quic_test...
net/quic/test_tools/quic_test_utils.cc:391: *bytes = string();
On 2013/11/04 01:58:27, wtc wrote:
> 
> Nit: would bytes->clear() be better?

Done.

https://codereview.chromium.org/54043003/diff/1/net/quic/test_tools/quic_test...
net/quic/test_tools/quic_test_utils.cc:398: *bytes =
string(reinterpret_cast<const char*>(&v[0]), v.size());
On 2013/11/04 01:58:27, wtc wrote:
> 
> Nit: this probably can be a bytes->append() call.

Done (using assign()).
> 
> It is s shame we have to copy from a vector to a string.

[commit-bot: I haz the power, 2013-11-04 19:57:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/54043003/110001

[commit-bot: I haz the power, 2013-11-04 20:49:40]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-04 21:18:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/54043003/370001

[wtc, 2013-11-04 23:46:40]

Patch set 3 LGTM.

[commit-bot: I haz the power, 2013-11-05 00:42:27]

Retried try job too often on win_rel for step(s) browser_tests,
chrome_frame_net_tests, chrome_frame_tests, content_unittests, nacl_integration,
sync_integration_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-05 01:23:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/54043003/370001

[commit-bot: I haz the power, 2013-11-05 03:12:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/54043003/370001

[commit-bot: I haz the power, 2013-11-05 03:59:55]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[wtc, 2013-11-28 16:23:21]

Eric: should we try to commit this CL again?

[commit-bot: I haz the power, 2013-12-02 20:16:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/54043003/370001

[eroman, 2013-12-02 20:16:44]

Thanks I hadn't noticed it failed!

Probably needs a rebase, but will quickly check the box again and see what
happens :)

[commit-bot: I haz the power, 2013-12-02 22:28:31]

Change committed as 238210