Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 540383002: Implementation of DevToolsBridgeServer. (Closed)

Created:
6 years, 3 months ago by SeRya
Modified:
6 years, 1 month ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@session
Project:
chromium
Visibility:
Public.

Description

Implementation of DevToolsBridgeServer. Basic functionality for android's server and tests. Isolated from GCD code. New button in the debugging activity causes equivalent result with previous one (tunnels a real DevTools socket to a fake one) but uses android service for that (2 ways of tasting may help in bug triaging). It lets test service life cycle and UI (foreground notification). BUG=383418 TEST=DevToolsBridgeServerTest, new button in debugging activity for manual testing Committed: https://crrev.com/853b6724ef2bf19c6181e40d364213bf3b3a7613 Cr-Commit-Position: refs/heads/master@{#300091}

Patch Set 1 #

Patch Set 2 : Rebased on WebRTC Java API. #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : Code review fixes #

Patch Set 5 : #

Patch Set 6 : findbugs fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+822 lines, -0 lines) Patch
A components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/DevToolsBridgeServer.java View 1 2 1 chunk +228 lines, -0 lines 0 comments Download
A components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/SignalingReceiver.java View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
A components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/ui/ServiceUIFactory.java View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download
A components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/util/LooperExecutor.java View 1 2 3 4 1 chunk +56 lines, -0 lines 0 comments Download
M components/devtools_bridge/android/javatests/AndroidManifest.xml View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/DevToolsBridgeServerTest.java View 1 2 3 4 5 1 chunk +94 lines, -0 lines 0 comments Download
M components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/tests/DebugActivity.java View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/tests/DebugService.java View 1 2 4 chunks +32 lines, -0 lines 0 comments Download
A components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/ClientSessionTestingHost.java View 1 2 1 chunk +92 lines, -0 lines 0 comments Download
A components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/DevToolsBridgeServerSandbox.java View 1 2 1 chunk +109 lines, -0 lines 0 comments Download
A components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/LocalBindingTestService.java View 1 2 3 4 5 1 chunk +121 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
SeRya
PTAL
6 years, 2 months ago (2014-10-02 11:31:31 UTC) #2
mnaganov (inactive)
https://codereview.chromium.org/540383002/diff/40001/components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/SignalingReceiver.java File components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/SignalingReceiver.java (right): https://codereview.chromium.org/540383002/diff/40001/components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/SignalingReceiver.java#newcode14 components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/SignalingReceiver.java:14: void startSession( Is it OK that there is no ...
6 years, 2 months ago (2014-10-02 14:48:00 UTC) #3
SeRya
https://codereview.chromium.org/540383002/diff/40001/components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/SignalingReceiver.java File components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/SignalingReceiver.java (right): https://codereview.chromium.org/540383002/diff/40001/components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/SignalingReceiver.java#newcode14 components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/SignalingReceiver.java:14: void startSession( On 2014/10/02 14:48:00, mnaganov (cr) wrote: > ...
6 years, 2 months ago (2014-10-03 09:49:35 UTC) #4
mnaganov (inactive)
lgtm
6 years, 2 months ago (2014-10-03 09:51:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/540383002/80001
6 years, 2 months ago (2014-10-17 08:56:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/13695)
6 years, 2 months ago (2014-10-17 09:40:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/540383002/100001
6 years, 2 months ago (2014-10-17 12:23:26 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years, 2 months ago (2014-10-17 12:40:16 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 12:40:54 UTC) #13
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/853b6724ef2bf19c6181e40d364213bf3b3a7613
Cr-Commit-Position: refs/heads/master@{#300091}

Powered by Google App Engine
This is Rietveld 408576698