Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 540373002: Add support for Low Priorirty tasks. (Closed)

Created:
6 years, 3 months ago by alex clarke (OOO till 29th)
Modified:
6 years, 2 months ago
Reviewers:
Sami, eseidel
CC:
blink-reviews, abarth-chromium, dglazkov+blink, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add support for Low Priorirty tasks. We are planning to make IPC tasks run on the main thread go through the blink scheduler. To support that, this patch adds postIpcTask which under the hood goes into a low priority task queue which gets executed in batches aligned to the nearest compositor deadline. That helps prevent preemption by high priority compositor tasks which would result in worse compositor task queueing durations. BUG=391005

Patch Set 1 #

Patch Set 2 : Fixed a compile issue with clang and removed the get prefix #

Patch Set 3 : Another compiler issue fixed. #

Patch Set 4 : Maybe fix linker issue #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -68 lines) Patch
M Source/platform/exported/WebSchedulerProxy.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/platform/scheduler/Scheduler.h View 1 5 chunks +38 lines, -5 lines 4 comments Download
M Source/platform/scheduler/Scheduler.cpp View 1 7 chunks +140 lines, -16 lines 0 comments Download
M Source/platform/scheduler/SchedulerTest.cpp View 1 2 10 chunks +131 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/wtf/CurrentTime.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/DoubleBufferedDeque.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/wtf/DoubleBufferedDequeTest.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
A + public/platform/WebBeginFrameArgs.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M public/platform/WebSchedulerProxy.h View 1 chunk +4 lines, -0 lines 0 comments Download
D public/web/WebBeginFrameArgs.h View 1 chunk +0 lines, -42 lines 0 comments Download
M public/web/WebWidget.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
We talked via our daily meeting about how another approach to these tasks mgith be ...
6 years, 3 months ago (2014-09-10 16:28:09 UTC) #2
jamesr
On 2014/09/10 16:28:09, eseidel wrote: > We talked via our daily meeting about how another ...
6 years, 3 months ago (2014-09-11 20:05:27 UTC) #3
eseidel
6 years, 3 months ago (2014-09-11 20:37:23 UTC) #4
Very possibly.  I could also imagine crazy solutions involving deferring JS
events until just before other JS is supposed to execute.

Powered by Google App Engine
This is Rietveld 408576698