Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1569)

Side by Side Diff: chromeos/network/onc/onc_validator.cc

Issue 540333002: ONC: Fix Static-/Saved-/IPConfig. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed another unit test. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/network/onc/onc_validator.h" 5 #include "chromeos/network/onc/onc_validator.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "base/json/json_writer.h" 10 #include "base/json/json_writer.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 } 96 }
97 97
98 scoped_ptr<base::DictionaryValue> Validator::MapObject( 98 scoped_ptr<base::DictionaryValue> Validator::MapObject(
99 const OncValueSignature& signature, 99 const OncValueSignature& signature,
100 const base::DictionaryValue& onc_object, 100 const base::DictionaryValue& onc_object,
101 bool* error) { 101 bool* error) {
102 scoped_ptr<base::DictionaryValue> repaired(new base::DictionaryValue); 102 scoped_ptr<base::DictionaryValue> repaired(new base::DictionaryValue);
103 103
104 bool valid = ValidateObjectDefault(signature, onc_object, repaired.get()); 104 bool valid = ValidateObjectDefault(signature, onc_object, repaired.get());
105 if (valid) { 105 if (valid) {
106 if (&signature == &kToplevelConfigurationSignature) 106 if (&signature == &kToplevelConfigurationSignature) {
107 valid = ValidateToplevelConfiguration(repaired.get()); 107 valid = ValidateToplevelConfiguration(repaired.get());
108 else if (&signature == &kNetworkConfigurationSignature) 108 } else if (&signature == &kNetworkConfigurationSignature) {
109 valid = ValidateNetworkConfiguration(repaired.get()); 109 valid = ValidateNetworkConfiguration(repaired.get());
110 else if (&signature == &kEthernetSignature) 110 } else if (&signature == &kEthernetSignature) {
111 valid = ValidateEthernet(repaired.get()); 111 valid = ValidateEthernet(repaired.get());
112 else if (&signature == &kIPConfigSignature) 112 } else if (&signature == &kIPConfigSignature ||
113 &signature == &kSavedIPConfigSignature ||
114 &signature == &kStaticIPConfigSignature) {
113 valid = ValidateIPConfig(repaired.get()); 115 valid = ValidateIPConfig(repaired.get());
114 else if (&signature == &kWiFiSignature) 116 } else if (&signature == &kWiFiSignature) {
115 valid = ValidateWiFi(repaired.get()); 117 valid = ValidateWiFi(repaired.get());
116 else if (&signature == &kVPNSignature) 118 } else if (&signature == &kVPNSignature) {
117 valid = ValidateVPN(repaired.get()); 119 valid = ValidateVPN(repaired.get());
118 else if (&signature == &kIPsecSignature) 120 } else if (&signature == &kIPsecSignature) {
119 valid = ValidateIPsec(repaired.get()); 121 valid = ValidateIPsec(repaired.get());
120 else if (&signature == &kOpenVPNSignature) 122 } else if (&signature == &kOpenVPNSignature) {
121 valid = ValidateOpenVPN(repaired.get()); 123 valid = ValidateOpenVPN(repaired.get());
122 else if (&signature == &kVerifyX509Signature) 124 } else if (&signature == &kVerifyX509Signature) {
123 valid = ValidateVerifyX509(repaired.get()); 125 valid = ValidateVerifyX509(repaired.get());
124 else if (&signature == &kCertificatePatternSignature) 126 } else if (&signature == &kCertificatePatternSignature) {
125 valid = ValidateCertificatePattern(repaired.get()); 127 valid = ValidateCertificatePattern(repaired.get());
126 else if (&signature == &kProxySettingsSignature) 128 } else if (&signature == &kProxySettingsSignature) {
127 valid = ValidateProxySettings(repaired.get()); 129 valid = ValidateProxySettings(repaired.get());
128 else if (&signature == &kProxyLocationSignature) 130 } else if (&signature == &kProxyLocationSignature) {
129 valid = ValidateProxyLocation(repaired.get()); 131 valid = ValidateProxyLocation(repaired.get());
130 else if (&signature == &kEAPSignature) 132 } else if (&signature == &kEAPSignature) {
131 valid = ValidateEAP(repaired.get()); 133 valid = ValidateEAP(repaired.get());
132 else if (&signature == &kCertificateSignature) 134 } else if (&signature == &kCertificateSignature) {
133 valid = ValidateCertificate(repaired.get()); 135 valid = ValidateCertificate(repaired.get());
136 }
134 } 137 }
135 138
136 if (valid) { 139 if (valid) {
137 return repaired.Pass(); 140 return repaired.Pass();
138 } else { 141 } else {
139 DCHECK(error_or_warning_found_); 142 DCHECK(error_or_warning_found_);
140 error_or_warning_found_ = *error = true; 143 error_or_warning_found_ = *error = true;
141 return scoped_ptr<base::DictionaryValue>(); 144 return scoped_ptr<base::DictionaryValue>();
142 } 145 }
143 } 146 }
(...skipping 692 matching lines...) Expand 10 before | Expand all | Expand 10 after
836 } 839 }
837 840
838 std::string Validator::MessageHeader() { 841 std::string Validator::MessageHeader() {
839 std::string path = path_.empty() ? "toplevel" : JoinString(path_, "."); 842 std::string path = path_.empty() ? "toplevel" : JoinString(path_, ".");
840 std::string message = "At " + path + ": "; 843 std::string message = "At " + path + ": ";
841 return message; 844 return message;
842 } 845 }
843 846
844 } // namespace onc 847 } // namespace onc
845 } // namespace chromeos 848 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/network/onc/onc_translator_shill_to_onc.cc ('k') | chromeos/network/onc/onc_validator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698