Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(96)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chromeos/test/data/network/ethernet.onc
Issue
540333002
:
ONC: Fix Static-/Saved-/IPConfig. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased.
Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chromeos/network/onc/onc_merger_unittest.cc
chromeos/network/onc/onc_normalizer.cc
chromeos/network/onc/onc_signature.cc
chromeos/network/onc/onc_translator_onc_to_shill.cc
chromeos/network/onc/onc_translator_shill_to_onc.cc
chromeos/network/onc/onc_validator.cc
chromeos/network/onc/onc_validator_unittest.cc
chromeos/test/data/network/augmented_merge.json
chromeos/test/data/network/device_policy.onc
chromeos/test/data/network/ethernet.onc
chromeos/test/data/network/invalid_settings_with_repairs.json
chromeos/test/data/network/managed_toplevel1.onc
chromeos/test/data/network/managed_vpn.onc
chromeos/test/data/network/managed_vpn_without_recommended.onc
chromeos/test/data/network/shill_ethernet.json
chromeos/test/data/network/translation_of_shill_ethernet.onc
chromeos/test/data/network/translation_of_shill_ethernet_with_ipconfig.onc
chromeos/test/data/network/user.onc
chromeos/test/data/network/vpn_active_settings.onc
View unified diff
|
Download patch
« chromeos/network/onc/onc_translator_onc_to_shill.cc
('K') |
« chromeos/test/data/network/device_policy.onc
('k') |
chromeos/test/data/network/invalid_settings_with_repairs.json »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 { "GUID": "guid",
1 { "GUID": "guid",
2 "Type": "Ethernet",
2 "Type": "Ethernet",
3 "Name": "name",
3 "Name": "name",
4 "Ethernet": {
4 "Ethernet": {
5 "Authentication": "None"
5 "Authentication": "None"
6
},
7
"StaticIPConfig":{
8
"Gateway":"1.1.1.7",
9
"IPAddress":"125.125.125.125",
10
"NameServers":[
11
"1.1.1.8",
12
"125.1.1.3"
13
],
14
"RoutingPrefix":26,
15
"Type":"IPv4"
6 }
16 }
7 }
17 }
OLD
NEW
« chromeos/network/onc/onc_translator_onc_to_shill.cc
('K') |
« chromeos/test/data/network/device_policy.onc
('k') |
chromeos/test/data/network/invalid_settings_with_repairs.json »
('j') |
no next file with comments »
Issue 540333002: ONC: Fix Static-/Saved-/IPConfig. (Closed)
Created 6 years, 3 months ago by pneubeck (no reviews)
Modified 6 years, 3 months ago
Reviewers: stevenjb
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 2
This is Rietveld
408576698