Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 540323002: Fixed missing dot in username (Closed)

Created:
6 years, 3 months ago by Roman Sorokin (ftl)
Modified:
6 years, 3 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed missing dot in username BUG=385740 Committed: https://crrev.com/172f59cdec7d8de26f3a1e7608790dca35b9d029 Cr-Commit-Position: refs/heads/master@{#293736}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Added logging #

Total comments: 1

Patch Set 3 : Update after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
Roman Sorokin (ftl)
nkostylev@, please review.
6 years, 3 months ago (2014-09-05 12:07:30 UTC) #2
Roman Sorokin (ftl)
https://codereview.chromium.org/540323002/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc File chrome/browser/chromeos/login/existing_user_controller.cc (left): https://codereview.chromium.org/540323002/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc#oldcode864 chrome/browser/chromeos/login/existing_user_controller.cc:864: if (!display_email_.empty()) { SaveUserDisplayEmail does nothing cause cannot find ...
6 years, 3 months ago (2014-09-05 12:10:35 UTC) #3
Nikita (slow)
lgtm https://codereview.chromium.org/540323002/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc File chrome/browser/chromeos/login/existing_user_controller.cc (right): https://codereview.chromium.org/540323002/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc#newcode870 chrome/browser/chromeos/login/existing_user_controller.cc:870: if (!display_email_.empty()) { On 2014/09/05 12:10:35, Roman Sorokin ...
6 years, 3 months ago (2014-09-08 09:33:20 UTC) #4
Nikita (slow)
lgtm lgtm https://codereview.chromium.org/540323002/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc File chrome/browser/chromeos/login/existing_user_controller.cc (right): https://codereview.chromium.org/540323002/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc#newcode870 chrome/browser/chromeos/login/existing_user_controller.cc:870: if (!display_email_.empty()) { On 2014/09/05 12:10:35, Roman ...
6 years, 3 months ago (2014-09-08 09:33:20 UTC) #5
Roman Sorokin (ftl)
nkostylev@, please review chrome/browser/chromeos/login/existing_user_controller.cc
6 years, 3 months ago (2014-09-08 11:54:35 UTC) #6
Roman Sorokin (ftl)
On 2014/09/08 11:54:35, Roman Sorokin wrote: > nkostylev@, please review > chrome/browser/chromeos/login/existing_user_controller.cc I meant components/user_manager/user_manager_base.cc
6 years, 3 months ago (2014-09-08 11:56:31 UTC) #7
Nikita (slow)
https://codereview.chromium.org/540323002/diff/20001/components/user_manager/user_manager_base.cc File components/user_manager/user_manager_base.cc (right): https://codereview.chromium.org/540323002/diff/20001/components/user_manager/user_manager_base.cc#newcode431 components/user_manager/user_manager_base.cc:431: LOG(ERROR) << "User not found"; nit: makes sense to ...
6 years, 3 months ago (2014-09-08 11:57:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsorokin@chromium.org/540323002/40001
6 years, 3 months ago (2014-09-08 12:41:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsorokin@chromium.org/540323002/40001
6 years, 3 months ago (2014-09-08 14:47:44 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as d4d68661bb24a9e7083f8b197651dc41c6dfc4c5
6 years, 3 months ago (2014-09-08 16:09:20 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:46:37 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/172f59cdec7d8de26f3a1e7608790dca35b9d029
Cr-Commit-Position: refs/heads/master@{#293736}

Powered by Google App Engine
This is Rietveld 408576698