Source/core/events/EventTarget.h - Issue 540283003: bindings: Retires ScriptWrappable::init, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/events/EventTarget.h

Issue 540283003: bindings: Retires ScriptWrappable::init, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed a review comment. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/events/EventTarget.h

diff --git a/Source/core/events/EventTarget.h b/Source/core/events/EventTarget.h

index 076c7e90f016177875a7604f1e565a388eee3d5f..5168bc008d43daf94f22d07be0f52bb596919aa3 100644

--- a/Source/core/events/EventTarget.h

+++ b/Source/core/events/EventTarget.h

@@ -87,8 +87,6 @@ public:

// errors.

// - If you added an onfoo attribute, use DEFINE_ATTRIBUTE_EVENT_LISTENER(foo)

// in your class declaration.

-// - Call ScriptWrappable::init(this) in your constructor, unless you are already

-// doing so.

// - Override EventTarget::interfaceName() and executionContext(). The former

// will typically return EventTargetNames::YourClassName. The latter will

// return ActiveDOMObject::executionContext (if you are an ActiveDOMObject)

« no previous file with comments | « Source/core/events/Event.cpp ('k') | Source/core/events/EventTarget.cpp » ('j') | no next file with comments »