Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: Source/bindings/core/v8/custom/V8DataViewCustom.cpp

Issue 540283003: bindings: Retires ScriptWrappable::init, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed a review comment. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptWrappable.h ('k') | Source/bindings/templates/interface_base.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8DataViewCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8DataViewCustom.cpp b/Source/bindings/core/v8/custom/V8DataViewCustom.cpp
index 98510a1411a4aecb6d46ffce1081607864b843e4..02b85b25256f51f32a247a8dd7a29c0d6844212d 100644
--- a/Source/bindings/core/v8/custom/V8DataViewCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8DataViewCustom.cpp
@@ -26,8 +26,6 @@
#include "config.h"
#include "bindings/core/v8/custom/V8DataViewCustom.h"
-#include "bindings/core/v8/V8Binding.h"
-#include "bindings/core/v8/custom/V8ArrayBufferViewCustom.h"
#include "bindings/core/v8/custom/V8TypedArrayCustom.h"
#include "core/html/canvas/DataView.h"
@@ -35,21 +33,4 @@ namespace blink {
const WrapperTypeInfo& DataView::s_wrapperTypeInfo = V8TypedArray<DataView>::wrapperTypeInfo;
-static void initializeScriptWrappableForInterface(DataView* object)
-{
- if (ScriptWrappable::wrapperCanBeStoredInObject(object))
- ScriptWrappable::fromObject(object)->setTypeInfo(&V8DataView::wrapperTypeInfo);
- else
- ASSERT_NOT_REACHED();
-}
-
} // namespace blink
-
-// In ScriptWrappable::init, the use of a local function declaration has an issue on Windows:
-// the local declaration does not pick up the surrounding namespace. Therefore, we provide this function
-// in the global namespace.
-// (More info on the MSVC bug here: http://connect.microsoft.com/VisualStudio/feedback/details/664619/the-namespace-of-local-function-declarations-in-c)
-void webCoreInitializeScriptWrappableForInterface(blink::DataView* object)
-{
- blink::initializeScriptWrappableForInterface(object);
-}
« no previous file with comments | « Source/bindings/core/v8/ScriptWrappable.h ('k') | Source/bindings/templates/interface_base.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698