Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: Source/core/html/track/vtt/VTTCue.cpp

Issue 540283003: bindings: Retires ScriptWrappable::init, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed a review comment. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/track/VideoTrackList.cpp ('k') | Source/core/html/track/vtt/VTTRegion.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Opera Software ASA. All rights reserved. 2 * Copyright (c) 2013, Opera Software ASA. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 , m_writingDirection(Horizontal) 216 , m_writingDirection(Horizontal)
217 , m_cueAlignment(Middle) 217 , m_cueAlignment(Middle)
218 , m_vttNodeTree(nullptr) 218 , m_vttNodeTree(nullptr)
219 , m_cueBackgroundBox(HTMLDivElement::create(document)) 219 , m_cueBackgroundBox(HTMLDivElement::create(document))
220 , m_displayDirection(CSSValueLtr) 220 , m_displayDirection(CSSValueLtr)
221 , m_displaySize(undefinedSize) 221 , m_displaySize(undefinedSize)
222 , m_snapToLines(true) 222 , m_snapToLines(true)
223 , m_displayTreeShouldChange(true) 223 , m_displayTreeShouldChange(true)
224 , m_notifyRegion(true) 224 , m_notifyRegion(true)
225 { 225 {
226 ScriptWrappable::init(this);
227 UseCounter::count(document, UseCounter::VTTCue); 226 UseCounter::count(document, UseCounter::VTTCue);
228 } 227 }
229 228
230 VTTCue::~VTTCue() 229 VTTCue::~VTTCue()
231 { 230 {
232 // Using oilpan, if m_displayTree is in the document it will strongly keep 231 // Using oilpan, if m_displayTree is in the document it will strongly keep
233 // the cue alive. Thus, if the cue is dead, either m_displayTree is not in 232 // the cue alive. Thus, if the cue is dead, either m_displayTree is not in
234 // the document or the entire document is dead too. 233 // the document or the entire document is dead too.
235 #if !ENABLE(OILPAN) 234 #if !ENABLE(OILPAN)
236 // FIXME: This is scary, we should make the life cycle smarter so the destru ctor 235 // FIXME: This is scary, we should make the life cycle smarter so the destru ctor
(...skipping 861 matching lines...) Expand 10 before | Expand all | Expand 10 after
1098 1097
1099 void VTTCue::trace(Visitor* visitor) 1098 void VTTCue::trace(Visitor* visitor)
1100 { 1099 {
1101 visitor->trace(m_vttNodeTree); 1100 visitor->trace(m_vttNodeTree);
1102 visitor->trace(m_cueBackgroundBox); 1101 visitor->trace(m_cueBackgroundBox);
1103 visitor->trace(m_displayTree); 1102 visitor->trace(m_displayTree);
1104 TextTrackCue::trace(visitor); 1103 TextTrackCue::trace(visitor);
1105 } 1104 }
1106 1105
1107 } // namespace blink 1106 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/html/track/VideoTrackList.cpp ('k') | Source/core/html/track/vtt/VTTRegion.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698