Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 540273002: Move app.currentWindowInternal API implementation to extensions (Closed)

Created:
6 years, 3 months ago by hashimoto
Modified:
6 years, 3 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move app.currentWindowInternal API implementation to extensions app_window_custom_bindings.js depends on currentWindowInternal. BUG=387288 Committed: https://crrev.com/575bc4ccd83d265e46e6214f8e1d2dea1b406432 Cr-Commit-Position: refs/heads/master@{#294112}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -729 lines) Patch
D chrome/browser/extensions/api/app_current_window_internal/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.h View 1 1 chunk +0 lines, -214 lines 0 comments Download
D chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 1 1 chunk +0 lines, -416 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/common/extensions/api/app_current_window_internal.idl View 1 1 chunk +0 lines, -69 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/browser/api/app_current_window_internal/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/browser/api/app_current_window_internal/app_current_window_internal_api.h View 1 2 chunks +5 lines, -6 lines 0 comments Download
A + extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc View 1 7 chunks +10 lines, -11 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 1 chunk +10 lines, -0 lines 0 comments Download
A + extensions/common/api/app_current_window_internal.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/common/api/schemas.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
hashimoto
6 years, 3 months ago (2014-09-05 10:08:08 UTC) #4
hashimoto
Ben, could you take a look at this change?
6 years, 3 months ago (2014-09-09 05:04:43 UTC) #5
benwells
lgtm
6 years, 3 months ago (2014-09-09 17:57:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/540273002/40001
6 years, 3 months ago (2014-09-10 04:48:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 9a94b10328ee87da68f412168774f39702d223c0
6 years, 3 months ago (2014-09-10 05:36:27 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 05:39:12 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/575bc4ccd83d265e46e6214f8e1d2dea1b406432
Cr-Commit-Position: refs/heads/master@{#294112}

Powered by Google App Engine
This is Rietveld 408576698