Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: src/compiler/value-numbering-reducer-unittest.cc

Issue 540253003: [turbofan] Nodes are killed by resetting all their inputs to zero. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Nit Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/value-numbering-reducer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/value-numbering-reducer-unittest.cc
diff --git a/src/compiler/value-numbering-reducer-unittest.cc b/src/compiler/value-numbering-reducer-unittest.cc
index 28a985605966c1240e131642ce51afff60585526..8db645803155112807edf86d7d8bbb742b9ef268 100644
--- a/src/compiler/value-numbering-reducer-unittest.cc
+++ b/src/compiler/value-numbering-reducer-unittest.cc
@@ -15,6 +15,7 @@ namespace compiler {
namespace {
const SimpleOperator kOp0(0, Operator::kNoProperties, 0, 1, "op0");
+const SimpleOperator kOp1(1, Operator::kNoProperties, 1, 1, "op1");
} // namespace
@@ -44,11 +45,12 @@ TEST_F(ValueNumberingReducerTest, AllInputsAreChecked) {
}
-TEST_F(ValueNumberingReducerTest, KilledNodesAreNeverReturned) {
- Node* n1 = graph()->NewNode(&kOp0);
+TEST_F(ValueNumberingReducerTest, DeadNodesAreNeverReturned) {
+ Node* n0 = graph()->NewNode(&kOp0);
+ Node* n1 = graph()->NewNode(&kOp1, n0);
EXPECT_FALSE(Reduce(n1).Changed());
n1->Kill();
- EXPECT_FALSE(Reduce(graph()->NewNode(&kOp0)).Changed());
+ EXPECT_FALSE(Reduce(graph()->NewNode(&kOp1, n0)).Changed());
}
« no previous file with comments | « src/compiler/value-numbering-reducer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698