Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Side by Side Diff: src/compiler/value-numbering-reducer-unittest.cc

Issue 540253003: [turbofan] Nodes are killed by resetting all their inputs to zero. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Nit Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/compiler/value-numbering-reducer.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits> 5 #include <limits>
6 6
7 #include "src/compiler/graph.h" 7 #include "src/compiler/graph.h"
8 #include "src/compiler/value-numbering-reducer.h" 8 #include "src/compiler/value-numbering-reducer.h"
9 #include "src/test/test-utils.h" 9 #include "src/test/test-utils.h"
10 10
11 namespace v8 { 11 namespace v8 {
12 namespace internal { 12 namespace internal {
13 namespace compiler { 13 namespace compiler {
14 14
15 namespace { 15 namespace {
16 16
17 const SimpleOperator kOp0(0, Operator::kNoProperties, 0, 1, "op0"); 17 const SimpleOperator kOp0(0, Operator::kNoProperties, 0, 1, "op0");
18 const SimpleOperator kOp1(1, Operator::kNoProperties, 1, 1, "op1");
18 19
19 } // namespace 20 } // namespace
20 21
21 22
22 class ValueNumberingReducerTest : public TestWithZone { 23 class ValueNumberingReducerTest : public TestWithZone {
23 public: 24 public:
24 ValueNumberingReducerTest() : graph_(zone()), reducer_(zone()) {} 25 ValueNumberingReducerTest() : graph_(zone()), reducer_(zone()) {}
25 26
26 protected: 27 protected:
27 Reduction Reduce(Node* node) { return reducer_.Reduce(node); } 28 Reduction Reduce(Node* node) { return reducer_.Reduce(node); }
28 29
29 Graph* graph() { return &graph_; } 30 Graph* graph() { return &graph_; }
30 31
31 private: 32 private:
32 Graph graph_; 33 Graph graph_;
33 ValueNumberingReducer reducer_; 34 ValueNumberingReducer reducer_;
34 }; 35 };
35 36
36 37
37 TEST_F(ValueNumberingReducerTest, AllInputsAreChecked) { 38 TEST_F(ValueNumberingReducerTest, AllInputsAreChecked) {
38 Node* na = graph()->NewNode(&kOp0); 39 Node* na = graph()->NewNode(&kOp0);
39 Node* nb = graph()->NewNode(&kOp0); 40 Node* nb = graph()->NewNode(&kOp0);
40 Node* n1 = graph()->NewNode(&kOp0, na); 41 Node* n1 = graph()->NewNode(&kOp0, na);
41 Node* n2 = graph()->NewNode(&kOp0, nb); 42 Node* n2 = graph()->NewNode(&kOp0, nb);
42 EXPECT_FALSE(Reduce(n1).Changed()); 43 EXPECT_FALSE(Reduce(n1).Changed());
43 EXPECT_FALSE(Reduce(n2).Changed()); 44 EXPECT_FALSE(Reduce(n2).Changed());
44 } 45 }
45 46
46 47
47 TEST_F(ValueNumberingReducerTest, KilledNodesAreNeverReturned) { 48 TEST_F(ValueNumberingReducerTest, DeadNodesAreNeverReturned) {
48 Node* n1 = graph()->NewNode(&kOp0); 49 Node* n0 = graph()->NewNode(&kOp0);
50 Node* n1 = graph()->NewNode(&kOp1, n0);
49 EXPECT_FALSE(Reduce(n1).Changed()); 51 EXPECT_FALSE(Reduce(n1).Changed());
50 n1->Kill(); 52 n1->Kill();
51 EXPECT_FALSE(Reduce(graph()->NewNode(&kOp0)).Changed()); 53 EXPECT_FALSE(Reduce(graph()->NewNode(&kOp1, n0)).Changed());
52 } 54 }
53 55
54 56
55 TEST_F(ValueNumberingReducerTest, OperatorEqualityNotIdentity) { 57 TEST_F(ValueNumberingReducerTest, OperatorEqualityNotIdentity) {
56 static const size_t kMaxInputCount = 16; 58 static const size_t kMaxInputCount = 16;
57 Node* inputs[kMaxInputCount]; 59 Node* inputs[kMaxInputCount];
58 for (size_t i = 0; i < arraysize(inputs); ++i) { 60 for (size_t i = 0; i < arraysize(inputs); ++i) {
59 Operator::Opcode opcode = static_cast<Operator::Opcode>( 61 Operator::Opcode opcode = static_cast<Operator::Opcode>(
60 std::numeric_limits<Operator::Opcode>::max() - i); 62 std::numeric_limits<Operator::Opcode>::max() - i);
61 inputs[i] = graph()->NewNode(new (zone()) SimpleOperator( 63 inputs[i] = graph()->NewNode(new (zone()) SimpleOperator(
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 111
110 TEST_F(ValueNumberingReducerTest, WontReplaceNodeWithItself) { 112 TEST_F(ValueNumberingReducerTest, WontReplaceNodeWithItself) {
111 Node* n = graph()->NewNode(&kOp0); 113 Node* n = graph()->NewNode(&kOp0);
112 EXPECT_FALSE(Reduce(n).Changed()); 114 EXPECT_FALSE(Reduce(n).Changed());
113 EXPECT_FALSE(Reduce(n).Changed()); 115 EXPECT_FALSE(Reduce(n).Changed());
114 } 116 }
115 117
116 } // namespace compiler 118 } // namespace compiler
117 } // namespace internal 119 } // namespace internal
118 } // namespace v8 120 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/value-numbering-reducer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698