Issue 540253003: [turbofan] Nodes are killed by resetting all their inputs to zero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 540253003: [turbofan] Nodes are killed by resetting all their inputs to zero. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer

Modified:
6 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Nodes are killed by resetting all their inputs to zero. TEST=compiler-unittests,mjsunit/numops-fuzz R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23725

Patch Set 2 : Nit #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -17 lines)			Patch
M	src/compiler/graph-reducer-unittest.cc	View		3 chunks	+15 lines, -12 lines	0 comments	Download
M	src/compiler/node.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/node.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/compiler/value-numbering-reducer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/value-numbering-reducer-unittest.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/540253003/diff/1/src/compiler/node.h File src/compiler/node.h (right): https://codereview.chromium.org/540253003/diff/1/src/compiler/node.h#newcode57 src/compiler/node.h:57: bool IsDead() const { return InputCount() && InputAt(0) ...

6 years, 3 months ago (2014-09-05 11:08:10 UTC) #2

Benedikt Meurer

6 years, 3 months ago (2014-09-05 11:10:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 23725 (presubmit successful).

Expand Messages | Collapse Messages

Issue 540253003: [turbofan] Nodes are killed by resetting all their inputs to zero. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Nit #

Messages