Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 540223002: Move FontFaceSet.{check,load}'s argument default into IDL file (Closed)

Created:
6 years, 3 months ago by Kunihiko Sakamoto
Modified:
6 years, 3 months ago
Reviewers:
tkent, bashi
CC:
blink-reviews, arv+blink, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Move FontFaceSet.{check,load}'s argument default into IDL file The default value of text parameter was handled in C++ code. Now the IDL parser supports optional default value syntax, let's use it. BUG= TEST=fast/css/font* Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M Source/core/css/FontFaceSet.cpp View 3 chunks +2 lines, -8 lines 0 comments Download
M Source/core/css/FontFaceSet.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Kunihiko Sakamoto
6 years, 3 months ago (2014-09-05 05:29:04 UTC) #2
tkent
lgtm
6 years, 3 months ago (2014-09-05 05:31:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/540223002/1
6 years, 3 months ago (2014-09-05 05:32:01 UTC) #5
bashi
LGTM
6 years, 3 months ago (2014-09-05 05:42:23 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 06:00:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181441

Powered by Google App Engine
This is Rietveld 408576698