chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js - Issue 540183002: Add search to Print Preview advanced options and enable them in the UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

Issue 540183002: Add search to Print Preview advanced options and enable them in the UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/settings/advanced_options_settings.js ('k') | chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings_item.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

diff --git a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

index 13f38c3d372047adc781c376dbb256b123876a99..5ab9d87c58101e259bf54c116507fe62168eb922 100644

--- a/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

+++ b/chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js

@@ -88,8 +88,7 @@ cr.define('print_preview', function() {

this.metrics_.record(print_preview.Metrics.PrintSettingsUiBucket.

ADVANCED_SETTINGS_DIALOG_SHOWN);

} else {

- this.searchBox_.setQuery(null);

- this.filterLists_(null);

+ this.resetSearch_();

this.destination_ = null;

}

@@ -127,6 +126,9 @@ cr.define('print_preview', function() {

* @private

filterLists_: function(query) {

+ this.items_.forEach(function(item) {

+ item.updateSearchQuery(query);

+ });

/**

@@ -173,7 +175,7 @@ cr.define('print_preview', function() {

* @private

onSearch_: function(evt) {

- this.filterLists_(evt.query);

+ this.filterLists_(evt.queryRegExp);

/**