chrome/browser/resources/print_preview/search/destination_search.js - Issue 540183002: Add search to Print Preview advanced options and enable them in the UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/search/destination_search.js

Issue 540183002: Add search to Print Preview advanced options and enable them in the UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/search/destination_list.js ('k') | chrome/browser/resources/print_preview/settings/advanced_options_settings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/search/destination_search.js

diff --git a/chrome/browser/resources/print_preview/search/destination_search.js b/chrome/browser/resources/print_preview/search/destination_search.js

index b2f8b0558215097bc5eb4fbfc47279cd4bc724fc..1d54473586aed1e2c199f320bbc6520465d5a59e 100644

--- a/chrome/browser/resources/print_preview/search/destination_search.js

+++ b/chrome/browser/resources/print_preview/search/destination_search.js

@@ -264,7 +264,7 @@ cr.define('print_preview', function() {

/**

* Filters all destination lists with the given query.

- * @param {?string} query Query to filter destination lists by.

+ * @param {RegExp} query Query to filter destination lists by.

* @private

filterLists_: function(query) {

@@ -450,7 +450,7 @@ cr.define('print_preview', function() {

* @private

onSearch_: function(evt) {

- this.filterLists_(evt.query);

+ this.filterLists_(evt.queryRegExp);

/**