Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 540163002: Revert of NaCl: Update revision in DEPS, r13679 -> r13687 (Closed)

Created:
6 years, 3 months ago by Derek Schuff
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of NaCl: Update revision in DEPS, r13679 -> r13687 (patchset #1 id:1 of https://codereview.chromium.org/537003002/) Reason for revert: This breaks NaCl SDK tests on mac (presumably because that's the only one using the 32-bit IRT). See https://code.google.com/p/nativeclient/issues/detail?id=3935 Original issue's description: > NaCl: Update revision in DEPS, r13679 -> r13687 > > This pulls in the following Native Client changes: > > r13680: (bradnelson) Add back in android_tools, but in the right location. > r13682: (dyen) Added irt extension support for supplying the nacl_irt_memory interface. > r13683: (bradnelson) Disabling flaky test under asan. > r13684: (hans) service_runtime_x86_64.gyp: pass /nologo to ml64.exe > r13685: (mseaborn) Use uint32_t for untrusted pointer args: mmap() and munmap() syscalls > r13686: (jfb) LLVM 3.5 merge: add missing dependencies to PNaCl build > r13687: (dschuff) Build x86-32 IRT with PNaCl > > R=mseaborn@chromium.org,bradnelson@chromium.org > BUG= https://code.google.com/p/nativeclient/issues/detail?id=3910 > TEST=browser_tests and nacl_integration > > Committed: https://chromium.googlesource.com/chromium/src/+/708bfbfe22cbc2bcd24a996211cd9a41da96e96e TBR=bradnelson@chromium.org,mseaborn@chromium.org,bradnelson@google.com NOTREECHECKS=true NOTRY=true BUG= https://code.google.com/p/nativeclient/issues/detail?id=3910 BUG= https://code.google.com/p/nativeclient/issues/detail?id=3935 Committed: https://crrev.com/d003d31fb884acff67f302ec9d7e6636e98a18bf Cr-Commit-Position: refs/heads/master@{#293375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Derek Schuff
Created Revert of NaCl: Update revision in DEPS, r13679 -> r13687
6 years, 3 months ago (2014-09-04 23:27:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/540163002/1
6 years, 3 months ago (2014-09-04 23:29:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3474f0da9f3093e828e91dc8ec0bfb1f3e0bd818
6 years, 3 months ago (2014-09-04 23:33:48 UTC) #3
Mark Seaborn
LGTM
6 years, 3 months ago (2014-09-04 23:39:33 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:34:01 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d003d31fb884acff67f302ec9d7e6636e98a18bf
Cr-Commit-Position: refs/heads/master@{#293375}

Powered by Google App Engine
This is Rietveld 408576698