Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Issue 540143002: InProcessGL: Share MailboxManager per service (Closed)

Created:
6 years, 3 months ago by no sievers
Modified:
6 years, 3 months ago
Reviewers:
danakj, boliu
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@clankium
Project:
chromium
Visibility:
Public.

Description

InProcessGL: Share MailboxManager per service The current logic ends up creating a MailboxManager per ContextGroup, so change this to share the mailbox manager across InProcessCommandBuffer::Service instances. This also allows for removing code in Android WebView that deals with passing around the share group. None of these contexts (child, parent compositor and video) need client-side share groups since mailbox names are used. TBR=tedchoc@chromium.org for content/public Committed: https://crrev.com/a5be71900477280bd56786b39493a3399b52dfdb Cr-Commit-Position: refs/heads/master@{#293902}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Messages

Total messages: 11 (4 generated)
no sievers
ptal https://codereview.chromium.org/540143002/diff/1/webkit/common/gpu/context_provider_in_process.cc File webkit/common/gpu/context_provider_in_process.cc (left): https://codereview.chromium.org/540143002/diff/1/webkit/common/gpu/context_provider_in_process.cc#oldcode57 webkit/common/gpu/context_provider_in_process.cc:57: attributes.shareResources = true; Let's see what the tests ...
6 years, 3 months ago (2014-09-04 21:03:08 UTC) #2
boliu
android_webview lgtm
6 years, 3 months ago (2014-09-04 21:29:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/540143002/20001
6 years, 3 months ago (2014-09-09 01:20:55 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-09 07:59:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/540143002/20001
6 years, 3 months ago (2014-09-09 08:06:18 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8f96b92bef506dc308f97516b7976a5a5cc5fa31
6 years, 3 months ago (2014-09-09 09:16:38 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:52:13 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a5be71900477280bd56786b39493a3399b52dfdb
Cr-Commit-Position: refs/heads/master@{#293902}

Powered by Google App Engine
This is Rietveld 408576698