Issue 540133002: Add v8_platform to the JS dependencies in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 540133002: Add v8_platform to the JS dependencies in the GN build. (Closed)

Created:
6 years, 3 months ago by brettw

Modified:
6 years, 3 months ago

Reviewers:
jam

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

Add v8_platform to the JS dependencies in the GN build. This is required for the call to v8::platform::CreateDefaultPlatform. R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e6e40abd9753c50917c1fc47f10c105ebe489e58

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

brettw

6 years, 3 months ago (2014-09-04 20:48:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as e6e40ab (presubmit successful).