Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1592)

Issue 540133002: Add v8_platform to the JS dependencies in the GN build. (Closed)

Created:
6 years ago by brettw
Modified:
6 years ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Add v8_platform to the JS dependencies in the GN build. This is required for the call to v8::platform::CreateDefaultPlatform. R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e6e40abd9753c50917c1fc47f10c105ebe489e58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
brettw
6 years ago (2014-09-04 20:38:38 UTC) #2
jam
lgtm
6 years ago (2014-09-04 20:42:52 UTC) #3
brettw
6 years ago (2014-09-04 20:48:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as e6e40ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698