chrome/browser/resources/extensions/extension_list.js - Issue 540113002: Reorder "action links" on chrome://extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 540113002: Reorder "action links" on chrome://extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_remove_install_from_webstore_flag

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/extensions/extensions.css » ('j') | chrome/browser/resources/extensions/extensions.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/extension_list.js

diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js

index f7e0b083cdb589534785a25c90fa35d19807a5db..1410193765546c1b8843946251fcd216a5e542b7 100644

--- a/chrome/browser/resources/extensions/extension_list.js

+++ b/chrome/browser/resources/extensions/extension_list.js

@@ -200,8 +200,8 @@ cr.define('options', function() {

var blacklistText = node.querySelector('.blacklist-text');

blacklistText.textContent = extension.blacklistText;

- var description = node.querySelector('.extension-description span');

- description.textContent = extension.description;

+ node.querySelector('.extension-description').appendChild(

+ document.createElement('span')).textContent = extension.description;

Dan Beam 2014/09/04 23:01:19 can you make this code less sly by adding temporar

Devlin 2014/09/04 23:28:09 Done. Lemme know if you want more/less.

// The 'Show Browser Action' button.

if (extension.enable_show_button) {