chrome/browser/resources/extensions/extensions.html - Issue 540113002: Reorder "action links" on chrome://extensions

Side by Side Diff: chrome/browser/resources/extensions/extensions.html

Issue 540113002: Reorder "action links" on chrome://extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_remove_install_from_webstore_flag

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/extensions/extensions.css ('K') | « chrome/browser/resources/extensions/extensions.css ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | chrome/common/extensions/manifest_url_handler.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="dir:textdirection;" class="loading">	2 <html i18n-values="dir:textdirection;" class="loading">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5	5

6 <link rel="stylesheet" href="extensions.css">	6 <link rel="stylesheet" href="extensions.css">

7 <link rel="stylesheet" href="extension_commands_overlay.css">	7 <link rel="stylesheet" href="extension_commands_overlay.css">

8 <link rel="stylesheet" href="extension_error.css">	8 <link rel="stylesheet" href="extension_error.css">

9 <link rel="stylesheet" href="extension_error_overlay.css">	9 <link rel="stylesheet" href="extension_error_overlay.css">

10 <link rel="stylesheet" href="extension_load_error.css">	10 <link rel="stylesheet" href="extension_load_error.css">

(...skipping 115 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
126	126

127 <div id="template-collection" hidden>	127 <div id="template-collection" hidden>

128	128

129 <div class="extension-list-item-wrapper">	129 <div class="extension-list-item-wrapper">

130 <div class="extension-list-item">	130 <div class="extension-list-item">

131 <div class="extension-details">	131 <div class="extension-details">

132 <div>	132 <div>

133 <span class="extension-title"></span>	133 <span class="extension-title"></span>

134 <span class="extension-version"></span>	134 <span class="extension-version"></span>

135 </div>	135 </div>

136 <p class="extension-description">	136 <p class="extension-description"></p>

137 <span></span>	137 <div class="action-links">

	138 <a class="options-link" i18n-content="extensionSettingsOptions"

	139 href="#" hidden></a>
	Dan Beam 2014/09/04 23:01:19 why is this an <a> if the [href] isn't useful? wh why is this an <a> if the [href] isn't useful? why not .link-button? Devlin 2014/09/04 23:28:10 For that most terrible of reasons: I copied the co Show quoted text On 2014/09/04 23:01:19, Dan Beam wrote: > why is this an <a> if the [href] isn't useful? why not .link-button? For that most terrible of reasons: I copied the code. Fixed them to make it better. :) Note, however, this results in the good/bad effect of only having the link underline for the details/developer website links. This is Good: It keeps in line with what we do everywhere else, saying "underline if it means navigate away", otherwise don't." Bad: It looks kinda weird to have one "randomly" underlined link in the row. Until told otherwise (possibly by UI team), I'm going to assume the good outweighs the bad in this case.
138 <a class="permissions-link"	140 <a class="permissions-link"

139 i18n-content="extensionSettingsPermissions"	141 i18n-content="extensionSettingsPermissions"

140 href="#">	142 href="#">

141 </a>	143 </a>

142 <a class="site-link" target="_parent" hidden></a>	144 <a class="site-link" target="_parent" hidden></a>

143 </p>	145 <a class="launch-link" i18n-content="extensionSettingsLaunch"

	146 href="#" hidden></a>

	147 <a class="reload-link"

	148 i18n-content="extensionSettingsReloadUnpacked"

	149 href="#" hidden></a>

	150 </div>

144 <div class="permanent-warnings">	151 <div class="permanent-warnings">

145 <div class="extension-warnings" hidden>	152 <div class="extension-warnings" hidden>

146 <span i18n-content="extensionSettingsWarningsTitle"></span>	153 <span i18n-content="extensionSettingsWarningsTitle"></span>

147 <ul></ul>	154 <ul></ul>

148 </div>	155 </div>

149 <div class="suspicious-install-message" hidden>	156 <div class="suspicious-install-message" hidden>

150 <span i18n-content="extensionSettingsSuspiciousInstall"></span>	157 <span i18n-content="extensionSettingsSuspiciousInstall"></span>

151 <a target="_blank" class="learn-more-link"	158 <a target="_blank" class="learn-more-link"

152 i18n-values="href:extensionSettingsSuspiciousInstallHelpUrl"	159 i18n-values="href:extensionSettingsSuspiciousInstallHelpUrl"

153 i18n-content="extensionSettingsLearnMore"	160 i18n-content="extensionSettingsLearnMore"

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
205 <span i18n-content="extensionSettingsEnableErrorCollection">	212 <span i18n-content="extensionSettingsEnableErrorCollection">

206 </span>	213 </span>

207 </label>	214 </label>

208 </div>	215 </div>

209 <div class="checkbox all-urls-control" hidden>	216 <div class="checkbox all-urls-control" hidden>

210 <label>	217 <label>

211 <input type="checkbox">	218 <input type="checkbox">

212 <span i18n-content="extensionSettingsAllowOnAllUrls"></span>	219 <span i18n-content="extensionSettingsAllowOnAllUrls"></span>

213 </label>	220 </label>

214 </div>	221 </div>

215 <span class="optional-controls-disableable">	222 <div class="checkbox file-access-control" hidden>

216 <label class="file-access-control" hidden>	223 <label>

217 <input type="checkbox">	224 <input type="checkbox">

218 <span i18n-content="extensionSettingsAllowFileAccess"></span>	225 <span i18n-content="extensionSettingsAllowFileAccess"></span>

219 </label>	226 </label>

220 <a class="reload-link"	227 </div>

221 i18n-content="extensionSettingsReloadUnpacked"

222 href="#" hidden></a>

223 <a class="launch-link" i18n-content="extensionSettingsLaunch"

224 href="#" hidden></a>

225 </span>

226 <a class="options-link" i18n-content="extensionSettingsOptions"

227 href="#" hidden></a>

228 </div>	228 </div>

229 <div class="butter-bar"	229 <div class="butter-bar"

230 i18n-values=".innerHTML:extensionSettingsIncognitoWarning" hidden>	230 i18n-values=".innerHTML:extensionSettingsIncognitoWarning" hidden>

231 </div>	231 </div>

232 </div>	232 </div>

233 <div class="enable-controls">	233 <div class="enable-controls">

234 <a class="terminated-reload-link" href="#"	234 <a class="terminated-reload-link" href="#"

235 i18n-content="extensionSettingsReloadTerminated" hidden></a>	235 i18n-content="extensionSettingsReloadTerminated" hidden></a>

236 <div class="checkbox enable-checkbox" hidden><label>	236 <div class="checkbox enable-checkbox" hidden><label>

237 <input type="checkbox">	237 <input type="checkbox">

(...skipping 24 matching lines...) Expand all Loading...
262 <include src="../../../../ui/webui/resources/html/trash.html">	262 <include src="../../../../ui/webui/resources/html/trash.html">

263 <include src="extension_error.html">	263 <include src="extension_error.html">

264	264

265 </div>	265 </div>

266	266

267 <script src="chrome://extensions-frame/strings.js"></script>	267 <script src="chrome://extensions-frame/strings.js"></script>

268 <script src="chrome://resources/js/i18n_template2.js"></script>	268 <script src="chrome://resources/js/i18n_template2.js"></script>

269	269

270 </body>	270 </body>

271 </html>	271 </html>

OLD	NEW