Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: chrome/browser/resources/extensions/extension_list.js

Issue 540113002: Reorder "action links" on chrome://extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_remove_install_from_webstore_flag
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 <include src="extension_error.js"> 5 <include src="extension_error.js">
6 6
7 /** 7 /**
8 * The type of the extension data object. The definition is based on 8 * The type of the extension data object. The definition is based on
9 * chrome/browser/ui/webui/extensions/extension_basic_info.cc 9 * chrome/browser/ui/webui/extensions/extension_basic_info.cc
10 * and 10 * and
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 193
194 var version = node.querySelector('.extension-version'); 194 var version = node.querySelector('.extension-version');
195 version.textContent = extension.version; 195 version.textContent = extension.version;
196 196
197 var locationText = node.querySelector('.location-text'); 197 var locationText = node.querySelector('.location-text');
198 locationText.textContent = extension.locationText; 198 locationText.textContent = extension.locationText;
199 199
200 var blacklistText = node.querySelector('.blacklist-text'); 200 var blacklistText = node.querySelector('.blacklist-text');
201 blacklistText.textContent = extension.blacklistText; 201 blacklistText.textContent = extension.blacklistText;
202 202
203 var description = node.querySelector('.extension-description span'); 203 node.querySelector('.extension-description').appendChild(
204 description.textContent = extension.description; 204 document.createElement('span')).textContent = extension.description;
Dan Beam 2014/09/04 23:01:19 can you make this code less sly by adding temporar
Devlin 2014/09/04 23:28:09 Done. Lemme know if you want more/less.
205 205
206 // The 'Show Browser Action' button. 206 // The 'Show Browser Action' button.
207 if (extension.enable_show_button) { 207 if (extension.enable_show_button) {
208 var showButton = node.querySelector('.show-button'); 208 var showButton = node.querySelector('.show-button');
209 showButton.addEventListener('click', function(e) { 209 showButton.addEventListener('click', function(e) {
210 chrome.send('extensionSettingsShowButton', [extension.id]); 210 chrome.send('extensionSettingsShowButton', [extension.id]);
211 }); 211 });
212 showButton.hidden = false; 212 showButton.hidden = false;
213 } 213 }
214 214
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
529 $('overlay').addEventListener('cancelOverlay', function() { 529 $('overlay').addEventListener('cancelOverlay', function() {
530 this.optionsShown_ = false; 530 this.optionsShown_ = false;
531 }.bind(this)); 531 }.bind(this));
532 }, 532 },
533 }; 533 };
534 534
535 return { 535 return {
536 ExtensionsList: ExtensionsList 536 ExtensionsList: ExtensionsList
537 }; 537 };
538 }); 538 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698