base/base_nacl.gyp - Issue 540093002: Don't build base with nacl glibc and newlib toolchains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base_nacl.gyp

Issue 540093002: Don't build base with nacl glibc and newlib toolchains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: also disable base_i18n newlib Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/base_nacl.gyp

diff --git a/base/base_nacl.gyp b/base/base_nacl.gyp

index 5ef664ce5beac38bc763196ee5e3e781071dbdd3..0816d316f38b1d4f9327328eb00d39080420f9df 100644

--- a/base/base_nacl.gyp

+++ b/base/base_nacl.gyp

@@ -20,8 +20,8 @@

'base_target': 1,

'nacl_untrusted_build': 1,

'nlib_target': 'libbase_nacl.a',

- 'build_glibc': 1,

- 'build_newlib': 1,

+ 'build_glibc': 0,

+ 'build_newlib': 0,

Mark Seaborn 2014/09/04 17:56:09 Does "build_newlib" mean "x86+newlib+gcc" or "newl

'build_irt': 1,

'build_pnacl_newlib': 1,

'sources': [

@@ -47,7 +47,7 @@

'nacl_untrusted_build': 1,

'nlib_target': 'libbase_i18n_nacl.a',

'build_glibc': 0,

- 'build_newlib': 1,

+ 'build_newlib': 0,

'build_irt': 0,

'build_pnacl_newlib': 1,

'sources': [

« no previous file with comments | « no previous file | no next file » | no next file with comments »