command_buffer: Table based command dispatch.

command_buffer: Table based command dispatch.

Changing command dispatch from a "switch" dispatch to table
based dispatch makes DoCommand about 2 times faster on
Android, and also seems to be reducing times in other
command_buffer code due to code size reduction.

BUG=394570
Committed: https://crrev.com/cd108598efea261241ac8b34ae225c179ed935a9
Cr-Commit-Position: refs/heads/master@{#293721}

[vmiura, 2014-09-05 18:20:05]

Patchset #2 (id:20001) has been deleted

[vmiura, 2014-09-05 18:20:11]

Patchset #1 (id:1) has been deleted

[vmiura, 2014-09-05 18:22:19]

vmiura@chromium.org changed reviewers:
+ piman@chromium.org

[vmiura, 2014-09-05 18:22:19]

ptal

[piman, 2014-09-05 22:10:17]

lgtm

https://codereview.chromium.org/540053004/diff/40001/gpu/command_buffer/servi...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/540053004/diff/40001/gpu/command_buffer/servi...
gpu/command_buffer/service/gles2_cmd_decoder.cc:3779: static CmdHandler
cmd_handlers[] = {
nit: can we fold this into g_command_info? It seems it would be a little more
cache friendly (and slightly less code).

[vmiura, 2014-09-05 22:35:44]

https://codereview.chromium.org/540053004/diff/40001/gpu/command_buffer/servi...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/540053004/diff/40001/gpu/command_buffer/servi...
gpu/command_buffer/service/gles2_cmd_decoder.cc:3779: static CmdHandler
cmd_handlers[] = {
On 2014/09/05 22:10:16, piman (OOO) wrote:
> nit: can we fold this into g_command_info? It seems it would be a little more
> cache friendly (and slightly less code).

Done.

[vmiura, 2014-09-05 22:35:51]

The CQ bit was checked by vmiura@chromium.org

[commit-bot: I haz the power, 2014-09-05 22:36:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vmiura@chromium.org/540053004/60001

[piman, 2014-09-05 22:38:54]

lgtm

[commit-bot: I haz the power, 2014-09-06 04:38:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-06 04:38:50]

Exceeded time limit waiting for builds to trigger.

[vmiura, 2014-09-08 14:34:58]

The CQ bit was checked by vmiura@chromium.org

[commit-bot: I haz the power, 2014-09-08 14:36:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vmiura@chromium.org/540053004/60001

[commit-bot: I haz the power, 2014-09-08 14:38:14]

Committed patchset #2 (id:60001) as 137e342a86bbbdc769e380c751c4e82aecbafa4c

[commit-bot: I haz the power, 2014-09-10 03:46:09]

Patchset 2 (id:??) landed as
https://crrev.com/cd108598efea261241ac8b34ae225c179ed935a9
Cr-Commit-Position: refs/heads/master@{#293721}