Issue 539933002: [turbofan] Make sure Operator is really immutable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 539933002: [turbofan] Make sure Operator is really immutable. (Closed)

Created:
6 years, 3 months ago by Benedikt Meurer

Modified:
6 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Make sure Operator is really immutable. Make Operator const-correct in preparation for allocating sharing Operators across different isolates (using LazyInstance). TEST=cctest,compiler-unittests,mjsunit R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23677

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -118 lines)			Patch
M	src/compiler/common-operator.h	View	4 chunks	+30 lines, -29 lines	0 comments	Download
M	src/compiler/graph-replay.h	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	src/compiler/graph-replay.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/js-inlining.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/node.h	View	4 chunks	+10 lines, -16 lines	0 comments	Download
M	src/compiler/node-matchers.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/operator.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/compiler/operator-properties.h	View	2 chunks	+26 lines, -27 lines	0 comments	Download
M	src/compiler/operator-properties-inl.h	View	7 chunks	+24 lines, -25 lines	0 comments	Download
M	src/compiler/simplified-operator.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/compiler/verifier.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/compiler/test-js-context-specialization.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Benedikt Meurer

6 years, 3 months ago (2014-09-04 09:37:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23677 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages