Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 539893003: Disable validation tests. (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
mkosiba (inactive), ppi
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable validation tests. Test are failing due to concurrent CL. Disabling those until they are fixed. R=ppi@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/f9898fa36aaa05bd0b0954aa4e3cd17fc76165d7 Cr-Commit-Position: refs/heads/master@{#293286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
qsr
6 years, 3 months ago (2014-09-04 10:39:19 UTC) #1
ppi
lgtm
6 years, 3 months ago (2014-09-04 10:41:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/539893003/1
6 years, 3 months ago (2014-09-04 10:43:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 349ba4e3fd60b72d484c86510f88785f69ffc534
6 years, 3 months ago (2014-09-04 10:48:18 UTC) #5
mkosiba (inactive)
this is not how you disable tests in Android. You need to import org.chromium.base.test.util.DisabledTest; and ...
6 years, 3 months ago (2014-09-04 11:35:16 UTC) #7
qsr
On 2014/09/04 11:35:16, mkosiba wrote: > this is not how you disable tests in Android. ...
6 years, 3 months ago (2014-09-04 12:16:00 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:31:00 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9898fa36aaa05bd0b0954aa4e3cd17fc76165d7
Cr-Commit-Position: refs/heads/master@{#293286}

Powered by Google App Engine
This is Rietveld 408576698