Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 539853002: Add file types to FileBrowser.ViewingFileType UMA stat. (Closed)

Created:
6 years, 3 months ago by iseki
Modified:
6 years, 3 months ago
Reviewers:
hirono, Mark P
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add file types to FileBrowser.ViewingFileType UMA stat. *.crdownload *.crx *.dmg *.exe *.html *.jar *.ps *.torrent *.txt *.zip BUG=397181 TEST=manually 1.Go to chrome://histogram. 2.Open the each file. 3.Confirtm the count is increased. Committed: https://crrev.com/d0de2976070eb55123d5a8228d76cf70cfffac04 Cr-Commit-Position: refs/heads/master@{#293455}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +11 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_tasks.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (5 generated)
iseki
Please take a look.
6 years, 3 months ago (2014-09-04 05:58:59 UTC) #2
hirono
On 2014/09/04 05:58:59, iseki wrote: > Please take a look. Please also update. https://code.google.com/p/chromium/codesearch#chromium/src/tools/metrics/histograms/histograms.xml&l=51188
6 years, 3 months ago (2014-09-04 06:23:39 UTC) #3
hirono
https://codereview.chromium.org/539853002/diff/1/ui/file_manager/file_manager/foreground/js/file_tasks.js File ui/file_manager/file_manager/foreground/js/file_tasks.js (right): https://codereview.chromium.org/539853002/diff/1/ui/file_manager/file_manager/foreground/js/file_tasks.js#newcode134 ui/file_manager/file_manager/foreground/js/file_tasks.js:134: '.crdownload', '.crx', '.dmg', '.doc', '.docx', '.exe', '.flac', '.gif', We ...
6 years, 3 months ago (2014-09-04 06:25:56 UTC) #4
iseki
Thank you for your review. https://codereview.chromium.org/539853002/diff/1/ui/file_manager/file_manager/foreground/js/file_tasks.js File ui/file_manager/file_manager/foreground/js/file_tasks.js (right): https://codereview.chromium.org/539853002/diff/1/ui/file_manager/file_manager/foreground/js/file_tasks.js#newcode134 ui/file_manager/file_manager/foreground/js/file_tasks.js:134: '.crdownload', '.crx', '.dmg', '.doc', ...
6 years, 3 months ago (2014-09-04 06:50:47 UTC) #5
hirono
lgtm with a nit. https://codereview.chromium.org/539853002/diff/20001/ui/file_manager/file_manager/foreground/js/file_tasks.js File ui/file_manager/file_manager/foreground/js/file_tasks.js (right): https://codereview.chromium.org/539853002/diff/20001/ui/file_manager/file_manager/foreground/js/file_tasks.js#newcode139 ui/file_manager/file_manager/foreground/js/file_tasks.js:139: '.html', '.jar', '.ps', '.torrent', '.txt', ...
6 years, 3 months ago (2014-09-04 06:57:25 UTC) #6
iseki
Thank you for your reveiw :) https://codereview.chromium.org/539853002/diff/20001/ui/file_manager/file_manager/foreground/js/file_tasks.js File ui/file_manager/file_manager/foreground/js/file_tasks.js (right): https://codereview.chromium.org/539853002/diff/20001/ui/file_manager/file_manager/foreground/js/file_tasks.js#newcode139 ui/file_manager/file_manager/foreground/js/file_tasks.js:139: '.html', '.jar', '.ps', ...
6 years, 3 months ago (2014-09-04 07:01:07 UTC) #7
iseki
Please take a look.
6 years, 3 months ago (2014-09-04 07:03:55 UTC) #9
iseki
@Mark P Please take a look following file: tools/metrics/histograms/histograms.xml
6 years, 3 months ago (2014-09-04 07:05:58 UTC) #10
Mark P
lgtm
6 years, 3 months ago (2014-09-04 18:23:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/539853002/40001
6 years, 3 months ago (2014-09-04 23:24:03 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/10431)
6 years, 3 months ago (2014-09-05 04:28:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iseki@chromium.org/539853002/40001
6 years, 3 months ago (2014-09-05 04:33:17 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001) as d0caf34b008819781f8687c25d09b3157d82ec5b
6 years, 3 months ago (2014-09-05 05:46:13 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:37:20 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d0de2976070eb55123d5a8228d76cf70cfffac04
Cr-Commit-Position: refs/heads/master@{#293455}

Powered by Google App Engine
This is Rietveld 408576698